Prevent future dates in date of birth picker#2955
Open
HeyangQin wants to merge 3 commits intoohs-foundation:masterfrom
Open
Prevent future dates in date of birth picker#2955HeyangQin wants to merge 3 commits intoohs-foundation:masterfrom
HeyangQin wants to merge 3 commits intoohs-foundation:masterfrom
Conversation
Add maxValue extension with cqf-calculatedValue of today() to the birthDate field in the patient registration questionnaire. The date picker already supports maxValue constraints — the questionnaire simply didn't include one. Closes ohs-foundation#835
- Future date (tomorrow) with maxValue of today() returns invalid - Today's date with maxValue of today() returns valid
Contributor
|
Thanks @HeyangQin for this PR. @LZRS, please check if this functionality works on the data capture Kotlin multiplatform version and if we added tests for the same. |
github-project-automation
Bot
moved this from New
to PR under Review
in Android FHIR SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxValueextension withcqf-calculatedValueoftoday()to the birthDate field in the patient registration questionnairemaxValueconstraints viaDatePickerViewHolderFactory.getSelectableDates()— the questionnaire simply didn't include oneTest plan
MaxValueValidatorTesttests pass — confirms cqf-calculatedValue with date constraints works correctlydatacaptureunit tests passCloses #835