fix: restore Cmd/Ctrl+Enter pure-annotation send (issue #17) - #18
Merged
Conversation
v1.3.18 (issue #10) excluded all modified Enter from attachAndSend, so Cmd/Ctrl+Enter could no longer send a pure annotation from an empty draft. Keep Shift/Alt+Enter excluded, but allow Cmd/Ctrl+Enter and submit directly in the capture phase to avoid the composer's accelerated steerQueue path leaving the annotation block visible in the input.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
issue #17 报告：空草稿保存批注后，Cmd/Ctrl+Enter 不能像普通 Enter 一样直接发送纯批注，必须先输入有效字符。
根因
v1.3.18 为修复 issue #10，把所有带修饰键的 Enter 排除在批注拼稿之外；因此 Cmd/Ctrl+Enter 到达宿主时仍是空草稿，提交被忽略，或在运行中有队列时误走整队插话。
修改
submit('queue')。验证
npm run checknpm testnpm pack --dry-run --jsongit diff --checkFixes #17