modules: Approvals + FileExchange reach full composition — EF stores + template flags - #172
Merged
Merged
Conversation
…+ template flags Database-backed stores land on the app's own DbContext (AddGoldpathApprovalModel / AddGoldpathFileExchangeModel; JSON-column trail; scope-per-call so engines stay singletons), proven on real SQLite storage: a restarted engine sees the same worklist, and zero-duplicate ingestion survives a restart. Template flags ship: dotnet new --features approvals/fileexchange generates manifest line, package, EF registration and model call — proven by generating AND building an app with both flags against the train's packages. CLI recipes mirror the template again (the invariant holds); 20+9 module tests, 133 CLI tests green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database-backed stores land on the app's own DbContext (AddGoldpathApprovalModel /
AddGoldpathFileExchangeModel; JSON-column trail; scope-per-call so engines stay
singletons), proven on real SQLite storage: a restarted engine sees the same
worklist, and zero-duplicate ingestion survives a restart. Template flags ship:
dotnet new --features approvals/fileexchange generates manifest line, package,
EF registration and model call — proven by generating AND building an app with
both flags against the train's packages. CLI recipes mirror the template again
(the invariant holds); 20+9 module tests, 133 CLI tests green.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com