Approvals v2: the six product-proven ladder rules - #185
Merged
Conversation
The api-portal product's approval engine proved six rules the ladder engine lacked; the owner accepted goldpath-approvals-v2 and they land here additively: - Withdraw: WithdrawAsync takes back a pending request, requester-only (NotRequester refusal), trailed. - Quorum rungs: GoldpathApprovalRung.RequiredApprovals (default 1); each grant is a signature toward the rung, completion at quorum. - Distinct-eyes across the chain: one identity signs at most once per request, held across escalation (AlreadySigned). - Mandatory rejection reason: a blank reason is refused (ReasonRequired). - Reject -> resubmit chain: ResubmitAsync links the fresh request by SupersedesId with both trails cross-referenced. - Store seam: AddSignatureAsync/GetSignaturesAsync on both stores; the EF store maps a GoldpathApprovalSignatures table. Proof: 50 new deterministic facts (v2 rules, EF restart/round-trip, model shape, composition seam, trail/refusal wording) beside the original 20, and the package joins the mutation gate (stryker/Goldpath.Approvals.json) at 79.13% against break 70. Ledgers: RFC flipped to accepted (owner, 2026-08-26) with the implementation record, RFC index and T21 addendum updated, package README documents the new verbs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements the accepted goldpath-approvals-v2 RFC: the six rules the api-portal product's approval engine proved live that the ladder engine lacked. All additive; the whole surface is still unshipped, so no shipped-API changes.
WithdrawAsync(id, requestedBy): requester-only (NotRequester), pending-only, trailed;Withdrawnstatus is terminal.GoldpathApprovalRung.RequiredApprovals(default 1): each grant is a signature toward the rung; completion at quorum; the trail readssigned (n/m)thengranted.AlreadySigned). Quorum counts per rung; the bar spans the whole chain.ReasonRequired); rejection stays terminal at any point, mid-quorum included.ResubmitAsync(rejectedId, requestedBy): fresh request linked bySupersedesId, both trails cross-referenced (resubmitted/superseded).AddSignatureAsync/GetSignaturesAsynconIGoldpathApprovalStore, in-memory and EF (GoldpathApprovalSignaturestable, indexed by request).Contract note: decision verbs keep refusal-as-value;
ResubmitAsyncthrows on misuse like the other creation verbs (RequestAsync,DelegateAsync).Proof
AddGoldpathApprovalsoverloads + config binding), and the trail/refusal wording an auditor reads.stryker/Goldpath.Approvals.json, score 79.13% against break 70.scripts/docs-freshness.shgreen;dotnet format --verify-no-changesclean on the touched projects.Ledgers (same PR as reality)
🤖 Generated with Claude Code