Skip to content

Remove provider block from module - #38

Open
dwhswenson wants to merge 1 commit into
mainfrom
remove-providers
Open

Remove provider block from module#38
dwhswenson wants to merge 1 commit into
mainfrom
remove-providers

Conversation

@dwhswenson

Copy link
Copy Markdown
Member

Since this is expected to be used as a module, we don't need to define the provider here. That should actually be done by the calling configuration.

This is a breaking change that will require updates in downstream configurations.

Assisted-by: Codex.app:GPT-5.6-Sol

Since this is expected to be used as a module, we don't need to define
the provider here. That should actually be done by the calling
configuration.

This is a breaking change that will require updates in downstream
configurations.

Assisted-by: Codex.app:GPT-5.6-Sol

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the AWS provider configuration from the root Terraform module so that provider configuration (including region) is defined by the calling/root configuration, which is the expected pattern for reusable modules.

Changes:

  • Removed the provider "aws" block from versions.tf.
  • Removed the now-unneeded aws_region input variable from variables.tf.
  • Updated the basic example to stop passing aws_region into the module.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
versions.tf Removes in-module AWS provider configuration so callers own provider setup.
variables.tf Drops aws_region module input since region is no longer configured inside the module.
examples/basic/main.tf Updates example module invocation to match the new module interface (no aws_region arg).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API break Breaking changes in the API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants