Remove provider block from module - #38
Open
dwhswenson wants to merge 1 commit into
Open
Conversation
Since this is expected to be used as a module, we don't need to define the provider here. That should actually be done by the calling configuration. This is a breaking change that will require updates in downstream configurations. Assisted-by: Codex.app:GPT-5.6-Sol
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the AWS provider configuration from the root Terraform module so that provider configuration (including region) is defined by the calling/root configuration, which is the expected pattern for reusable modules.
Changes:
- Removed the
provider "aws"block fromversions.tf. - Removed the now-unneeded
aws_regioninput variable fromvariables.tf. - Updated the basic example to stop passing
aws_regioninto the module.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| versions.tf | Removes in-module AWS provider configuration so callers own provider setup. |
| variables.tf | Drops aws_region module input since region is no longer configured inside the module. |
| examples/basic/main.tf | Updates example module invocation to match the new module interface (no aws_region arg). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this is expected to be used as a module, we don't need to define the provider here. That should actually be done by the calling configuration.
This is a breaking change that will require updates in downstream configurations.
Assisted-by: Codex.app:GPT-5.6-Sol