Bug fixes in 1286 - #1288
Closed
joepio wants to merge 2 commits into
Closed
Conversation
…ount repair - Fix action errors stringifying label function instead of calling it - Fix explicit choice flag blocking local drive restore on Tauri - Fix count repair treating local surplus as stale data
All three fixes in this branch had already landed on the base branch in 381eaf6, in a more complete form: - Action label: base also guards `action.label(ctx)` against throwing, so a failing label cannot swallow the error the toast exists to report. - Count repair: base kept the surplus guard for a while and then reverted the whole count probe in bd83cea — it fired a query per collection and broke the tested "refresh does not refetch known resources" invariant. The real cause was server-side and is fixed in 6c83924. - Tauri drive restore: base restores in the `did:` branch (`wasExplicitlyChosen() ? get() : getLocalServerOrigin()`) rather than by persisting the foreign origin. Dropping the `!isRunningInTauri()` guard, as this branch did, would store that origin on Tauri and clear the explicit marker — reinstating the bug where one visit to an `https://…/drive/…` entry left the app booting against that server. Every conflict is therefore resolved to the base version, and the merged tree is identical to it.
Member
Author
|
Closing: this branch no longer contributes anything. All three fixes landed on the base branch independently, in a more complete form:
The merge I pushed here ( |
An error occurred while trying to automatically change base from
fix/sync-nodes-index-and-ui
to
develop
August 21, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains changes generated by a Cursor Cloud Agent
Cursor generated this PR to address Bugbot findings on PR #1286. If that PR is closed, this PR will be closed automatically. Configure in dashboard.