Skip to content

fix(lib): genesis-only offline save must not rewind the outbox forever - #1302

Merged
joepio merged 1 commit into
developfrom
cursor/fix-full-e2e-b7ed
Aug 21, 2026
Merged

fix(lib): genesis-only offline save must not rewind the outbox forever#1302
joepio merged 1 commit into
developfrom
cursor/fix-full-e2e-b7ed

Conversation

@joepio

@joepio joepio commented Aug 21, 2026

Copy link
Copy Markdown
Member

Related Issues

Unbreaks develop full Playwright after #1301. The quoting fix let the suite run; this is the actual test failure:

https://github.com/ontola/atomic-server/actions/runs/32518361794

offline-create-then-online failed all 3 attempts:

waitForSynced timed out. pendingDirtyCount: 1, syncInProgress: true, hasSignedGenesis: false

Cause

saveOffline stored the local genesis cursor as a rewind baseVersion. The comment already said to skip that when nothing had been server-acked; the code did not.

On reconnect the drain POSTed genesis, then the empty follow-up export looked like "OPFS not ready" and the outbox retried forever. The default ontology of an extra drive is genesis-only, so it was the stranded entry.

Fix

  • Do not set baseVersion when a signedGenesis is still unposted.
  • If this drain pass POSTed genesis and the follow-up export is empty, clear the dirty bit.

Covered by browser/lib/src/offline-create-drain.test.ts. Commit is tagged [full-e2e] so this PR runs the same suite that failed on develop.

Checklist

  • Add or update tests if needed
  • Update docs if needed (TESTING_COVERAGE.md)
Open in Web Open in Cursor 

saveOffline treated the local genesis cursor as a last-synced baseline.
Reconnect POSTed genesis, then the empty follow-up export looked like
"OPFS not ready" and the outbox retried forever — pendingDirtyCount
stuck at 1, hasSignedGenesis false. That is the develop full-e2e
failure of offline-create-then-online after #1301 unblocked the suite.

Co-authored-by: joepmeindertsma <joepmeindertsma@gmail.com>
@joepio
joepio marked this pull request as ready for review August 21, 2026 20:20
@joepio
joepio merged commit ebabda7 into develop Aug 21, 2026
6 checks passed
@joepio
joepio deleted the cursor/fix-full-e2e-b7ed branch August 21, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants