fix(lib): genesis-only offline save must not rewind the outbox forever - #1302
Merged
Conversation
saveOffline treated the local genesis cursor as a last-synced baseline. Reconnect POSTed genesis, then the empty follow-up export looked like "OPFS not ready" and the outbox retried forever — pendingDirtyCount stuck at 1, hasSignedGenesis false. That is the develop full-e2e failure of offline-create-then-online after #1301 unblocked the suite. Co-authored-by: joepmeindertsma <joepmeindertsma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Unbreaks develop full Playwright after #1301. The quoting fix let the suite run; this is the actual test failure:
https://github.com/ontola/atomic-server/actions/runs/32518361794
offline-create-then-onlinefailed all 3 attempts:Cause
saveOfflinestored the local genesis cursor as a rewindbaseVersion. The comment already said to skip that when nothing had been server-acked; the code did not.On reconnect the drain POSTed genesis, then the empty follow-up export looked like "OPFS not ready" and the outbox retried forever. The default ontology of an extra drive is genesis-only, so it was the stranded entry.
Fix
baseVersionwhen asignedGenesisis still unposted.Covered by
browser/lib/src/offline-create-drain.test.ts. Commit is tagged[full-e2e]so this PR runs the same suite that failed on develop.Checklist
TESTING_COVERAGE.md)