Fix Firefox page transitions - #1357
Open
joepio wants to merge 1 commit into
Open
Conversation
Scope snapshot sizing by view-transition-class so card-to-page morphs fill the group instead of exploding sideways, make title links inline-block to avoid Firefox IB-split duplicate names, and skip a hung startViewTransition overlay so navigation still completes. Co-authored-by: joepmeindertsma <joepmeindertsma@gmail.com>
joepio
marked this pull request as ready for review
September 4, 2026 07:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Page transitions on Firefox were broken: card-to-page morphs exploded into a giant overlay that covered the sidebar, and a duplicate
view-transition-name(including Firefox’s false duplicates from inline/block splits) could skip the whole transition or leave the overlay covering the page.What changed
view-transition-class: titles still scale by height (no horizontal smear), resource-page morphs fill the group withobject-fit: cover.inline-blockso Firefox does not treat a named inline<a>as an IB-split duplicate (bug 1999336).:rootgets an explicit height so Firefox’s root snapshot is not stretched (bug 1962617).startViewTransitionfailures and hungfinishedpromises still navigate and callskipTransition(), so a Firefox capture error cannot freeze the UI.Firefox verification
Headed Firefox 150: a named inline
<a>wrapping a heading rejects withDuplicate view-transition-name value while capturing old state;display: inline-blockon the same link isready-ok. The old global height-based snapshot rule overlaps the sidebar mid-morph; the newresource-pageclass keeps the morph in the main panel.Grid before the morph
Broken CSS mid-morph overlapping the sidebar
firefox-page-transitions.mp4
Checklist
TESTING_COVERAGE.md)To show artifacts inline, enable in settings.