fix(browser): vault backup BigInt argument; onboarding dev-build _w_ctx_ error - #1376
Merged
Conversation
… onboarding dev build threw _w_ctx_ Two develop-head failures that atomic-saas's portal e2e surfaced once its CI stopped pinning atomic-server: - client-db.worker.ts handed checkpoint_n to the WASM vaultExport as a Number; wasm-bindgen wants a BigInt for a u64 and threw 'Cannot convert 1 to a BigInt' on every automatic backup. - In RecoveryBackupStep one button's JSX text made the i18n extractor emit the nested-message form (_w_runtime_.x(_w_ctx_)) without the enclosing callback, so the dev build threw '_w_ctx_ is not defined' on every onboarding run. The label is a script-scope string now; verified on the vite-transformed module that no bare context reference remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two develop-head failures that atomic-saas's portal e2e surfaced once its CI stopped pinning atomic-server (ontola/atomic-saas#53).
Cannot convert 1 to a BigInton every automatic Cloud Vault backup:client-db.worker.tspassedcheckpointNas a Number, butvaultExport'scheckpoint_nis au64and wasm-bindgen requires a BigInt. NowBigInt(msg.checkpointN)._w_ctx_ is not definedinRecoveryBackupStepin the vite dev build: for one button label the i18n extractor (wuchale) emitted the nested-message form_w_runtime_.x(_w_ctx_)without the enclosing callback. The label is a script-scope string now. Verified on the transformed module served by vite that the only remaining_w_ctx_references sit inside their callbacks.Unblocks the portal e2e in ontola/atomic-saas#53, which in turn unblocks #1375.