feat(connector): default proxy --method to GET - #360
Merged
Conversation
`oo connector proxy` required `--method` even for the plain lookups that make up most proxy calls, which is friction curl users do not expect. The request schema now defaults `method` to `GET`, so both the split flags and the `--data` object can omit it, and the `--method` required error is gone. Any non-GET request still needs an explicit method. The bundled skill reference keeps `--method GET` in its canonical forms on purpose, so agents always pass the method explicitly and do not depend on the default. Signed-off-by: Kevin Cui <bh@bugs.cc>
|
Warning Review limit reached
On-demand reviews are free for the next 20 days. After that, they cost $0.25 per reviewed file. Or wait 37 minutes for your next included review. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 53 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (5)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oo connector proxyrequired--methodon every call, including the plain lookups that make up most proxy requests, which is friction curl users do not expect. The request schema now defaultsmethodtoGET, so both the split flags and the--dataobject can omit it, and the "--method is required" error is gone. Non-GET requests still need an explicit method, and the new CLI tests cover both input forms plus the telemetrymethodproperty.The bundled skill reference deliberately keeps
--method GETin its canonical forms so agents always pass the method explicitly rather than relying on the default. Only docs/commands.md and docs/commands.zh-CN.md document the new default.