feat: surface validation errors and recommendations in the editor#46
Merged
Conversation
Wire packageErrors/packageRecommendations from @open-audio-stack/core into the metadata editor as inline warnings, so authors see schema issues and non-blocking recommendations before submitting. - Errors and recommendations only appear once the user actually changes a value (edits a field or the YAML directly), not on initial/blank load, so a freshly loaded form isn't immediately flooded with warnings. Loading a different template resets the baseline used for this comparison. - Nothing is blocked - Copy/Download/Submit via GitHub remain usable regardless of errors or recommendations. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The core library already computes rich validation feedback (
packageErrors— Zod schema violations — andpackageRecommendations— non-blocking suggestions like missing arm64 support), but the site's metadata editor never surfaced it. Authors could submit a package via GitHub with no idea it would fail registry validation, or miss easy improvements.Editor, rendering two inline lists below the YAML editor: errors (red) and recommendations (amber).packageErrors/packageRecommendationsalready behave everywhere else (they don't throw; onlyPackage.addVersiondoes, server-side).Test plan
npm run lint— cleannpm run build— compiles, type-checks, static export succeedsnpm test— 1/1 passing🤖 Generated with Claude Code