Skip to content

os: Implement os::Event - #80

Open
Nitr4m12 wants to merge 1 commit into
open-ead:masterfrom
Nitr4m12:event
Open

os: Implement os::Event#80
Nitr4m12 wants to merge 1 commit into
open-ead:masterfrom
Nitr4m12:event

Conversation

@Nitr4m12

@Nitr4m12 Nitr4m12 commented Sep 7, 2026

Copy link
Copy Markdown

The class itself is similar to os::Mutex, in that it's mostly a wrapper around global functions, so this follows a similar structure to #78.


This change is Reviewable

Comment thread include/nn/os/os_Event.h Outdated

@MonsterDruide1 MonsterDruide1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 4 files and all commit messages, and made 5 comments.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on Nitr4m12 and Pistonight).


a discussion (no related file):
add new files to CMakeLists.txt


include/nn/os/os_Event.h line 47 at r2 (raw file):

};

}  // namespace nn::os

add newline at end of file


include/nn/os/os_EventCommon.h line 4 at r2 (raw file):

namespace nn::os {
enum EventClearMode { EventClearMode_ManualClear, EventClearMode_AutoClear };

or does this cause issues with symbols/compiling somewhere?

Suggestion:

enum class EventClearMode { ManualClear, AutoClear };

include/nn/os/os_EventCommon.h line 5 at r2 (raw file):

namespace nn::os {
enum EventClearMode { EventClearMode_ManualClear, EventClearMode_AutoClear };
}  // namespace nn::os

add newline at end of file


include/nn/os/os_EventTypes.h line 26 at r2 (raw file):

static_assert(std::is_trivial<EventType>::value, "EventType non trivial");

}  // namespace nn::os

add newline at end of file

@Nitr4m12 Nitr4m12 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nitr4m12 reviewed 5 files and all commit messages, and made 5 comments.
Reviewable status: 1 of 5 files reviewed, 6 unresolved discussions (waiting on MonsterDruide1 and Pistonight).


a discussion (no related file):

Previously, MonsterDruide1 wrote…

add new files to CMakeLists.txt

Done


include/nn/os/os_Event.h line 47 at r2 (raw file):

Previously, MonsterDruide1 wrote…

add newline at end of file

Done


include/nn/os/os_EventCommon.h line 4 at r2 (raw file):

Previously, MonsterDruide1 wrote…

or does this cause issues with symbols/compiling somewhere?

This causes issues when compiling sead


include/nn/os/os_EventCommon.h line 5 at r2 (raw file):

Previously, MonsterDruide1 wrote…

add newline at end of file

Done


include/nn/os/os_EventTypes.h line 26 at r2 (raw file):

Previously, MonsterDruide1 wrote…

add newline at end of file

Done

@MonsterDruide1 MonsterDruide1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 4 files and all commit messages, and resolved 5 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Pistonight).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants