Skip to content

os: fix ThreadType size for newer sdk versions - #81

Open
Pistonight wants to merge 1 commit into
open-ead:masterfrom
Pistonight:thread_type
Open

os: fix ThreadType size for newer sdk versions#81
Pistonight wants to merge 1 commit into
open-ead:masterfrom
Pistonight:thread_type

Conversation

@Pistonight

@Pistonight Pistonight commented Sep 9, 2026

Copy link
Copy Markdown

StartThread extracts the handle for syscall and the offset for handle was different -
inspected GetTlsValue and SwitchToFiber and narrowed down to this field


This change is Reviewable

@MonsterDruide1 MonsterDruide1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Pistonight).


include/nn/os/os_ThreadTypes.h line 42 at r1 (raw file):

    FiberType* _initialFiber;
    // may be inaccurate: SDK 4.4.0 has the field while 7.3.2 and 20.5.6 does not
#if NN_SDK_VER >= NN_MAKE_VER(5, 0, 0)

The comment doesn't match the logic here?
Preprocessor currently adds it for versions higher than 5, meaning that it would exist on 7 and 20, while nonexistant on 4.

Code quote:

    // may be inaccurate: SDK 4.4.0 has the field while 7.3.2 and 20.5.6 does not
#if NN_SDK_VER >= NN_MAKE_VER(5, 0, 0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants