os: fix ThreadType size for newer sdk versions - #81
Open
Pistonight wants to merge 1 commit into
Open
Conversation
MonsterDruide1
requested changes
Sep 9, 2026
MonsterDruide1
left a comment
There was a problem hiding this comment.
@MonsterDruide1 reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Pistonight).
include/nn/os/os_ThreadTypes.h line 42 at r1 (raw file):
FiberType* _initialFiber; // may be inaccurate: SDK 4.4.0 has the field while 7.3.2 and 20.5.6 does not #if NN_SDK_VER >= NN_MAKE_VER(5, 0, 0)
The comment doesn't match the logic here?
Preprocessor currently adds it for versions higher than 5, meaning that it would exist on 7 and 20, while nonexistant on 4.
Code quote:
// may be inaccurate: SDK 4.4.0 has the field while 7.3.2 and 20.5.6 does not
#if NN_SDK_VER >= NN_MAKE_VER(5, 0, 0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StartThread extracts the handle for syscall and the offset for handle was different -
inspected GetTlsValue and SwitchToFiber and narrowed down to this field
This change is