Skip to content

[Enhancement] Bump protobuf to 3.20.3 - #2658

Open
mys007 wants to merge 1 commit into
open-mmlab:mainfrom
mys007:protobuf-bump
Open

[Enhancement] Bump protobuf to 3.20.3#2658
mys007 wants to merge 1 commit into
open-mmlab:mainfrom
mys007:protobuf-bump

Conversation

@mys007

@mys007 mys007 commented Jan 24, 2024

Copy link
Copy Markdown

Motivation

There are still many Python packages around which stick with the old 3.20 protobuf version. However, this is typically the very last release of major version 3: 3.20.3. Unfortunately, mmdeploy enforces constraint of 3.20.2, which leads to unnecessary incompatibilities.

Modification

I propose to bump the patch version of protobuf to 3.20.3. This is very likely of no relevance to mmdeploy but makes cohabitation with many other packages possible.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Bump protobuf
@CLAassistant

CLAassistant commented Jan 24, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@mys007

mys007 commented Mar 4, 2024

Copy link
Copy Markdown
Author

Just bumping this, could "build / build_cuda117" be rerun? It failed without a good reason. Thanks:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants