Don't crash if FMUs log with category=NULL#797
Merged
Conversation
|
Ser bra ut dette. |
Member
Author
|
I don't understand the build failures. I don't think they are related to this particular PR, and I can't reproduce them locally even using the same Conan version as that used in CI. |
Member
Author
|
Tested locally with an fmiCpp FMU provided by @SSkjong and confirmed that it works: 
|
Member
Author
|
@davidhjp01, @restenb, do any of you have any idea what is going on in the Linux CI builds here? |
Contributor
I also had the same issue, try this changes: |
Member
Author
|
I think the fix in #801 should take care of the build issues here. I'll update as soon as that one is merged. |
This fixes issue #796.
kyllingstad
force-pushed
the
bugfix/796-logger-null-category
branch
from
6459f24 to
75fff96
Compare
Member
Author
|
@davidhjp01, can we do a release after merging this? Other software depends on this fix. |
davidhjp01
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #796.
We don't have any straightforward way to test this right now, since our test FMUs aren't easily modifiable. Perhaps @SSkjong, who discovered the issue, can test with the FMU that triggered it?