Upgrade CMake to v4#802
Merged
Merged
Conversation
…for all build types
This reverts commit 071dcd9.
davidhjp01
changed the title
kyllingstad
reviewed
May 18, 2026
| self.requires("boost/[~1.85]", transitive_headers=True, transitive_libs=True) # Required by Thrift | ||
| if self.options.proxyfmu: | ||
| self.requires("proxyfmu/0.4.1@osp/stable", | ||
| self.requires("proxyfmu/0.4.1@osp/testing-cmake-v4", |
Member
There was a problem hiding this comment.
I guess this should be reverted before merging.
Contributor
Author
There was a problem hiding this comment.
I will updated it to stable version after releasing proxyfmu
| apt-get update | ||
| apt-get install -y pipx cmake doxygen | ||
| pipx install conan | ||
| pipx install conan cmake |
Member
There was a problem hiding this comment.
Is this necessary? It seems strange to install CMake via the Python package system. Won't CMake be installed by Conan due to the tool_requires() directive in conanfile.py?
Contributor
Author
There was a problem hiding this comment.
Yeah, I thought so too, but since it was originally installing conan via apt, I just moved it here for updating it to the latest version. I can try removing it
Member
There was a problem hiding this comment.
Maybe also try removing the APT install, so we are sure it's using the Conan-installed one.
kyllingstad
approved these changes
May 18, 2026
kyllingstad
added a commit
that referenced
this pull request
May 18, 2026
This fixes #800 by making changes to the Conan+Linux CI workflow. The official Conan Center docker image we were using has now been deprecated (all of them have), so I have switched to using the official GCC image instead. This required a GCC version upgrade. The oldest supported version is 12, but I went with 14 so we can stay on the same version for a while. (GCC 15 is the newest, at the time of writing.) I also replaced the roundabout process we had of generating our own Docker image to using Github Actions' built-in facilities for choosing an image. This also fixes #798 by updating the Conan options syntax for both Conan workflows, and updates the build system to use CMake 4 (#802, thanks to @davidhjp01). --------- Co-authored-by: David Heejong Park <88651540+davidhjp01@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade CMake to v4