Switch tracepoint to fetch - #658
Open
thompson-tomo wants to merge 7 commits into
Open
Conversation
Removed option to build tracepoints library from CMake configuration.
thompson-tomo
marked this pull request as ready for review
August 19, 2026 06:00
thompson-tomo
changed the title
dbarker
reviewed
Aug 19, 2026
dbarker
reviewed
Aug 19, 2026
dbarker
left a comment
dbarker
left a comment
Member
There was a problem hiding this comment.
Thanks! Removing the submodule and switch to FetchContent look good.
Only concern with this change is removal of the BUILD_TRACEPOINTS option since it is referenced by the vcpkg port (the main consumer of this contrib component).
Safer to keep the option for this PR and follow up if needed on removing it.
Contributor
Author
|
I thought that option was used only in the section that was removed hence why i removed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches tracepoint from gitmodule to a fetch content.