fix: required user agent header - #662
Merged
marcalff merged 9 commits intoAug 29, 2026
Merged
Conversation
…ntrib into fix-required-user-agent-header
lalitb
reviewed
Aug 20, 2026
lalitb
approved these changes
Aug 20, 2026
lalitb
left a comment
lalitb
left a comment
Member
There was a problem hiding this comment.
LGTM. The CentOS 7 failure appears unrelated to this change. The container seems to fail during yum install git because vault.centos.org returns HTTP 403, before the module is built or the new regression test runs.
…y-cpp-contrib into fix-required-user-agent-header
…roost/opentelemetry-cpp-contrib into fix-required-user-agent-header
…r-agent-header' of github.com:proost/opentelemetry-cpp-contrib; branch 'main' of github.com:open-telemetry/opentelemetry-cpp-contrib into fix-required-user-agent-header
…y-cpp-contrib into fix-required-user-agent-header
…roost/opentelemetry-cpp-contrib into fix-required-user-agent-header
marcalff
removed
the
pr:fix-merge-conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #474
Current implementation assumed that user agent header always exists. But it didn't. So i adding check.
It is quite difficult to add unit test case. If have any idea, I will happily accept it.