ci: Resolving nginx & prometheus build issue - #667
Conversation
thompson-tomo
changed the title
thompson-tomo
changed the title
thompson-tomo
changed the title
thompson-tomo
changed the title
| include(FetchContent) | ||
|
|
||
| link_directories(${CMAKE_ARCHIVE_OUTPUT_DIRECTORY}) | ||
| set(ENABLE_TESTING OFF CACHE BOOL "") |
There was a problem hiding this comment.
Can you check this once - it seems to be disabling the test for both dependencies and the exporter. Also seen this in CI:
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
No tests were found!!! ??
| include(CMakePackageConfigHelpers) | ||
| file(MAKE_DIRECTORY "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/cmake/${PROJECT_NAME}") | ||
|
|
||
| configure_package_config_file( |
There was a problem hiding this comment.
With this removal, the downstream CMake projects can no longer discover and link the installed exporter through its existing package target.
There was a problem hiding this comment.
Has this been resolved with the newer commits?
|
Thanks for continuing to improve the CI across contrib - these fixes are really appreciated. For this PR, the NGINX changes look good. Please revisit the Prometheus CMake workflow and dependency changes so we preserve the existing test, dependency, and packaging contracts. |
|
I am quite confused about the prometheus package purpose on the surface it should be an exporter just like user_events, however when you look at the cmake its name indicates otherwise. If the name is correct then shouldn't there be a file in the root for the contrib repo & enable the prometheus to mirror other exporters. In the case of the later then the name etc should be updated. |
| opentelemetry-cpp-contrib | ||
| VERSION "1.19.0" # opentelemetry-cpp-contrib 1.19.0 | ||
| HOMEPAGE_URL "https://github.com/open-telemetry/opentelemetry-cpp-contrib" |
There was a problem hiding this comment.
This doesn't look right. Shouldn't the name have prometheus?
2 participants
NGINX instrumentation build failures have been addressed by explicitly using buildx & switching tests to use php docker image which exists. Have also updated the tests to use nil for remote-parent-id rather than empty string.
Prometheus bazel build resolved by specifying an older bazel version to use.
Prometheus cmake build resolved by changing zlib adding process as well as switching to a native cmake build.
This is a replacement for #633 which i accidentally broke which triggered the closing of it.