[CODE HEALTH] fix clang-tidy cppcoreguidelines-pro-type-const-cast warnings

[Anish701]

Fixes #4477

Changes

Resolves all cppcoreguidelines-pro-type-const-cast warnings by eliminating const_cast usage through proper typing .

• examples/http: Accept const T& in HttpTextMapCarrier constructor, removing the need to const_cast request headers.
• ext/http/client/curl: Change SetCurlPtrOption to accept const void*, and silence const_cast warning for string data.
• ext/test/w3c_tracecontext_http_test_server: Copy headers by value instead of const_casting a reference.
• sdk/common/circular_buffer.h: Make PeekImpl() a const method, eliminating the const_cast<CircularBuffer*>(this) in Peek().

• CHANGELOG.md updated for non-trivial changes - N/A this is a trivial code health change
• Unit tests have been added - N/A
• Changes in public API reviewed - yes mentioned in description

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Anish701 / name: Anish Sinha (4297c36)
• ✅ login: Anish701 / name: Anish701 (d2890d8)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.24%. Comparing base (8b8c871) to head (5b8cf88).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4482      +/-   ##
==========================================
- Coverage   83.25%   83.24%   -0.01%     
==========================================
  Files         521      521              
  Lines       20381    20379       -2     
==========================================
- Hits        16966    16962       -4     
- Misses       3415     3417       +2     

Files with missing lines	Coverage Δ
...lemetry/ext/http/client/curl/http_operation_curl.h	90.91% <100.00%> (-0.39%)	⬇️
ext/src/http/client/curl/http_operation_curl.cc	60.60% <100.00%> (ø)
...include/opentelemetry/sdk/common/circular_buffer.h	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[marcalff]

@Anish701

Thanks for the cleanup patch.

Note: The methods MultiObserverResult::ForInstrument and MultiObserverResult::HasInstrument have their parameters changed from const ObservableInstrument* to ObservableInstrument*. The previous const qualifier was misleading because there was a const_cast on the pointer. Also, all existing callers already pass non-const pointers. This is not a breaking change to the API. All unit tests pass successfully.

I don't think this is the proper fix, and it is a breaking change to the API: what if an existing application invokes opentelemetry with a const pointer today ?

Please avoid changing this area, in favor of #4499 which is a different fix.

[marcalff]

Thanks for the patch.

Please revert changes related to metrics instruments, to be fixed separately.

Please revert changes related to CURL blob parameters, and silence the warning instead.

Everything else looks ok.

[Anish701]

Thanks for the patch.

Please revert changes related to metrics instruments, to be fixed separately.

Please revert changes related to CURL blob parameters, and silence the warning instead.

Everything else looks ok.

@marcalff Thanks for reviewing! I reverted the metrics related changes. I also reverted the changes to the CURL blob params and silenced the warnings with // NOLINTNEXTLINE(cppcoreguidelines-pro-type-const-cast).

Please let me know if any other changes are needed. Thanks!

[marcalff]

LGTM, thanks for the cleanup.

[dbarker]

Thanks for the fixes. Please update the warning limits in the CI workflow to subtract the 10 fixed const-cast warnings.
See .github/workflows/clang-tidy.yaml#L20

[Anish701]

Thanks for the fixes. Please update the warning limits in the CI workflow to subtract the 10 fixed const-cast warnings. See .github/workflows/clang-tidy.yaml#L20

@dbarker Sounds good. I subtracted 10 from both abiv1 and abiv2 warning limits