build: exclude standalone root crates from the workspace#1205
build: exclude standalone root crates from the workspace#1205chaodu-agent wants to merge 1 commit into
Conversation
cargo errors with 'current package believes it's in a workspace when it's not' when tooling runs inside a repo-root crate (openab-agent, agy-acp, openab-auth-proxy, operator) that is neither a workspace member nor excluded. This breaks the CI openab-agent job's 'cargo fmt --check' step on the release tag checkout (fails in ~18s before any real checks run). Add these standalone crates to [workspace].exclude. Each has its own Cargo.lock and dedicated CI, so they are intentionally not workspace members.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
LGTM ✅ — Minimal, correct fix for cargo workspace resolution error affecting standalone crates. What This PR DoesFixes CI failures (specifically How It WorksAdds Findings
Finding Details🟢 F1: Correct cargo mechanismThe 🟢 F2: Comprehensive coverageRather than fixing only 🟢 F3: Good documentationThe inline comment explains why the exclusion exists, which helps future contributors understand the workspace topology. Baseline Check
What's Good (🟢)
|
Summary
Fixes the long-standing CI openab-agent failure (present since at least v0.9.0-beta.2). On the release-tag checkout, the job's first step
cargo fmt --check(run fromopenab-agent/) dies in ~18s with:The repo root has four standalone crates —
openab-agent,agy-acp,openab-auth-proxy,operator— that are neither workspacemembersnorexcluded. cargo therefore refuses to operate inside them. (Regular PRs happened to pass, but the release-tag checkout reliably hits it.)Fix
Add the standalone root crates to
[workspace].exclude. Each has its ownCargo.lockand dedicated CI, so they are intentionally not part of the root workspace. This is the cargo-recommended resolution and prevents the same latent failure for the sibling crates too.Verification
Reproduced before/after locally (replicating the CI step):
Root workspace still resolves:
cargo metadata --no-depsOK. The crate itself is healthy (clippy/test pass on normal PRs).