Skip to content

fix(workbench): parse UTC timestamps on Python 3.10 - #462

Open
mldangelo-oai wants to merge 4 commits into
mainfrom
mdangelo/codex/fix-python310-scan-timestamps
Open

fix(workbench): parse UTC timestamps on Python 3.10#462
mldangelo-oai wants to merge 4 commits into
mainfrom
mdangelo/codex/fix-python310-scan-timestamps

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Restore Deep Scan deadlines and remediation-claim expiration on supported Python 3.10 installations.

Fixes #35. Fixes #450.

Changes

  • Normalize UTC suffixes before parsing Deep Scan deadlines, coordinator heartbeats, and remediation claims.
  • Preserve stored timestamps, explicit timezone offsets, exact lease cutoffs, and the existing handling of invalid or timezone-naive claims.
  • Keep the bundled-plugin version paired at 0.1.21 so cached installations receive the fix.
  • Merge current main without changing the reviewed timestamp patch.

Testing

  • Existing timestamp suites on ceca62b5: 20 passed with Python 3.10.19 and tomli==2.3.0; the same 20 passed with Python 3.14.5.
  • Existing plugin-cache regression: one passed. The focused checks total 41 executions, zero failures, and 84 assertions.
  • Python 3.10 syntax, paired-version validation, pnpm run types, pnpm run format, and git diff --check: passed.
  • Build, pack, check:package, and separate installed-package smoke: passed. The archive contains 222 entries and 106 bundled plugin files; the installed smoke exercised the nested worker without a global Codex installation.
  • The earlier randomized full suite on 21c1a776 passed 1,313 tests with 11 skips and zero failures. That result is historical; a new full suite was not run for this unchanged main integration.
  • Three fresh source-only native reviews and independent verification passed with no findings. Pushed-head CI is still required.

Risk and rollout

No persisted data is rewritten, and deadline and lease semantics are unchanged. The npm package version is unchanged. Main currently uses plugin 0.1.20; if another plugin-changing PR lands first, merge that main additively, advance both plugin version fields monotonically, and rerun the current-head cache/version and review checks.

Public disclosure review

Newly authored material was reviewed for public disclosure. Existing automated review comments contain access-restricted report references; maintainer cleanup remains outstanding.

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Aug 15, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 8a9606167d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 8a9606167d

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current head, 21c1a7764a0a18b302c0380855b6402980de1b22.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 21c1a7764a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 21c1a7764a

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai
mldangelo-oai marked this pull request as ready for review August 16, 2026 07:31

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed Python 3.10 timestamp compatibility, lease handling, and the synchronized bundled-plugin version.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: ceca62b568

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: ceca62b568

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

2 participants