Skip to content

fix: normalize Windows configuration paths - #492

Merged
faizan-oai merged 3 commits into
mainfrom
agent/fix-windows-config-paths
Aug 18, 2026
Merged

fix: normalize Windows configuration paths#492
faizan-oai merged 3 commits into
mainfrom
agent/fix-windows-config-paths

Conversation

@faizan-oai

Copy link
Copy Markdown
Contributor

Summary

Severity: P1–P2. Windows path spelling, environment-key casing, home-relative values, and machine-wide configuration could cause valid Codex Security settings to be missed or resolved against the wrong location. This makes those inputs resolve consistently while preserving existing configuration precedence.

Changes

  • Expand home-relative paths at CLI, runtime, comparison, and Deep Scan configuration boundaries.
  • Match Windows environment keys and equivalent filesystem aliases using Windows semantics.
  • Load machine-wide preflight configuration from ProgramData and recognize aliased project trust paths.
  • Add focused coverage for path spelling, casing, aliases, and configured Python selection.

Testing

  • pnpm run format — passed.
  • pnpm run types — passed.
  • pnpm run build — passed.
  • Focused Windows configuration-path regressions — 10 passed.
  • git diff --check origin/main...HEAD — passed.

Risk and rollout

The changes are limited to configuration discovery and path normalization. Existing precedence remains unchanged, and non-Windows path behavior is preserved apart from explicit home expansion where the CLI already accepts a path. No migration or rollout step is required.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@faizan-oai
faizan-oai force-pushed the agent/fix-windows-config-paths branch from ebc3b06 to 1779fc9 Compare August 17, 2026 18:35
@faizan-oai faizan-oai changed the title Fix Windows configuration path normalization fix: normalize Windows configuration paths Aug 17, 2026
@github-actions github-actions Bot added the bug Something isn't working label Aug 17, 2026
@faizan-oai
faizan-oai force-pushed the agent/fix-windows-config-paths branch from 1634968 to 9aa9b31 Compare August 17, 2026 20:13
@faizan-oai
faizan-oai force-pushed the agent/fix-windows-config-paths branch from f806da9 to 6c18515 Compare August 17, 2026 20:25
@faizan-oai
faizan-oai marked this pull request as ready for review August 17, 2026 20:35

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6c185159fefe for correctness and simplification. One optional test simplification. The production changes preserve the intended configuration precedence.

This is a non-blocking review. I did not run the full SDK suite or native Windows tests locally.

Comment thread sdk/typescript/tests-ts/api.test.ts Outdated
mldangelo-oai
mldangelo-oai previously approved these changes Aug 17, 2026

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked 6c18515. The earlier simplification suggestions remain non-blocking. Approving the reviewed head.

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed 020c2b3, including the test-only update since the earlier approval. The previous review thread is addressed, and I found no new blocking issue.

CI is green on this head, including Windows, but the branch still conflicts with main in sdk/typescript/src/cli.ts. The resolution should retain both resolveCliPath(directory, input) and lstat(path, { bigint: true }). A fresh approval should be attached to the conflict-free replacement head after its checks pass.

Local validation: the diff whitespace check and focused Python preflight smoke checks passed. I did not run the full SDK suite or native Windows tests locally.

@faizan-oai
faizan-oai merged commit bfa6eb5 into main Aug 18, 2026
33 checks passed
@faizan-oai
faizan-oai deleted the agent/fix-windows-config-paths branch August 18, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants