Skip to content

fix: handle Windows multiscan path aliases - #496

Open
faizan-oai wants to merge 1 commit into
mainfrom
agent/fix-windows-multiscan-path-aliases
Open

fix: handle Windows multiscan path aliases#496
faizan-oai wants to merge 1 commit into
mainfrom
agent/fix-windows-multiscan-path-aliases

Conversation

@faizan-oai

Copy link
Copy Markdown
Contributor

Summary

Severity: P1–P2. Creating a new campaign below a Windows junction can fail before multiscan reaches the scanner, and equivalent repository aliases can prevent a campaign from resuming. This canonicalizes the stable filesystem portions used for creation and comparison.

Changes

  • Resolve the nearest existing campaign ancestor before recursive directory creation on Windows.
  • Canonicalize existing local repository paths before multiscan records or compares them.
  • Preserve the validated canonical campaign directory for subsequent operations.
  • Add Windows junction and repository-alias regressions.

Testing

  • pnpm run format — passed.
  • pnpm run types — passed.
  • pnpm run build — passed.
  • Focused Windows multiscan alias regressions — 2 passed.
  • git diff --check origin/main...HEAD — passed.

Risk and rollout

User-selected parent junctions remain supported, while linked output directories and post-validation redirection protections remain unchanged. Canonicalization applies only to existing local paths. No migration is required.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@faizan-oai faizan-oai changed the title Handle Windows multiscan path aliases fix: handle Windows multiscan path aliases Aug 17, 2026
@github-actions github-actions Bot added the bug Something isn't working label Aug 17, 2026
@faizan-oai
faizan-oai marked this pull request as ready for review August 17, 2026 20:18

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed e1a84b4a190f for correctness and simplification. One optional consolidation with the related portable-path PR.

This is a non-blocking review. I did not run the full SDK suite or native Windows tests locally.

Comment thread sdk/typescript/src/multiscan.ts

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked e1a84b4. The earlier simplification suggestions remain non-blocking. Approving the reviewed head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants