fix: handle Windows multiscan path aliases - #496
Open
faizan-oai wants to merge 1 commit into
Open
Conversation
faizan-oai
marked this pull request as ready for review
August 17, 2026 20:18
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed e1a84b4a190f for correctness and simplification. One optional consolidation with the related portable-path PR.
This is a non-blocking review. I did not run the full SDK suite or native Windows tests locally.
mldangelo-oai
approved these changes
Aug 17, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Rechecked e1a84b4. The earlier simplification suggestions remain non-blocking. Approving the reviewed head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Severity: P1–P2. Creating a new campaign below a Windows junction can fail before multiscan reaches the scanner, and equivalent repository aliases can prevent a campaign from resuming. This canonicalizes the stable filesystem portions used for creation and comparison.
Changes
Testing
pnpm run format— passed.pnpm run types— passed.pnpm run build— passed.git diff --check origin/main...HEAD— passed.Risk and rollout
User-selected parent junctions remain supported, while linked output directories and post-validation redirection protections remain unchanged. Canonicalization applies only to existing local paths. No migration is required.
Public disclosure review