Skip to content

test: verify the installed SDK TypeScript contract - #507

Open
mldangelo-oai wants to merge 6 commits into
mdangelo/codex/test-properties-and-mutationfrom
mdangelo/codex/test-installed-package-types
Open

test: verify the installed SDK TypeScript contract#507
mldangelo-oai wants to merge 6 commits into
mdangelo/codex/test-properties-and-mutationfrom
mdangelo/codex/test-installed-package-types

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Validate the published package from a strict TypeScript consumer, including the public constructor boundary.

Part 3 of 4 in the test-quality stack. Depends on #506; merge the earlier stack layers first.

Changes

  • Compile a consumer against the installed tarball with strict NodeNext settings and without skipLibCheck.
  • Exercise the public scan, progress, cost, and cleanup types.
  • Add a negative type assertion that fails if the internal constructor becomes public again.
  • Keep this layer test-only now that the declaration fixes have landed on main.

Testing

  • Refreshed head 654a0790, Bun 1.3.14, seed 1: 116 API and public-surface tests passed.
  • On the tree-equivalent head ec19497b, type checking, formatting, packing, and inspection of the actual archive passed.
  • Those installed-package checks included strict NodeNext compilation, CLI execution, 230 archive entries, and the nested worker.
  • Three fresh native reviews and independent verification of 654a0790: no findings.
  • The full supported-runtime CI matrix passed on tree-equivalent head ec19497b. It will rerun on the refreshed head.

Risk and rollout

This layer changes only the package-consumer fixture and smoke-check script. The declaration fixes are already in the parent, so there is no additional runtime or declaration change. The stricter check is intended to fail when published declarations cannot be consumed or expose the internal constructor overload.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current head 496bc455b502960346728659e5d0481974afc5b8.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 17, 2026

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 496bc455b5

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 496bc455b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator Author

CI note for 496bc455b502960346728659e5d0481974afc5b8: the first node-ci attempt had two Windows timeouts in unchanged paths: a scan-recovery test waiting on Python and npm installation in the package smoke check. I reran only the failed jobs. Attempt 2 passed on the same commit; the recovery case finished in 3.30 seconds, and the installed NodeNext package check passed. No code or timeout changes were made for the retry.

@mldangelo-oai
mldangelo-oai marked this pull request as ready for review August 17, 2026 22:21

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the refreshed head b178a833ca2edcf5093bfecff54c268cffe7610a. The additive restack also excludes an internal scan-event helper from emitted declarations. The actual installed tarball now passes strict NodeNext compilation without skipLibCheck; the public API and runtime behavior are unchanged. Fresh package and native review gates passed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: b178a833ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 17, 2026

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: b178a833ca

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the refreshed head ec19497b52bb36c01bf6748e5b82beec362a2f7e. The layer now changes only the installed-consumer fixture and smoke-check script; the declaration corrections are already in the parent. Please check the strict NodeNext and internal-constructor regression checks.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: ec19497b52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator Author

@codex security review

Please review the exact refreshed head ec19497b52bb36c01bf6748e5b82beec362a2f7e. This layer changes only the installed-package consumer fixture and smoke-check script.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: ec19497b52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review refreshed head 654a07908c758ba359c13290a9a88d587237346b against the now main-based #506. Its Git tree is unchanged from ec19497b; the 116 focused API/public-surface tests and three fresh native reviews with independent verification passed again. The layer remains limited to the installed-consumer fixture and smoke-check script.

Copy link
Copy Markdown
Collaborator Author

@codex security review

Please review exact refreshed head 654a07908c758ba359c13290a9a88d587237346b. Only the installed-package consumer fixture and smoke-check script remain in this layer.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 654a07908c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants