ci: allow slower Windows integration tests - #509
Merged
Conversation
Collaborator
Author
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
Author
|
The Codex security review of commit |
mldangelo-oai
marked this pull request as ready for review
August 17, 2026 22:16
faizan-oai
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give Windows CI integration tests enough time to finish. In the failed main run, the API shard timed out while validating knowledge-base documents and preparing a managed credential home. The document test ran for about 58 seconds before reporting the existing 30-second timeout.
The separate multiscan failure in that run is already covered by #494. This PR does not duplicate that production fix.
Changes
Testing
Using Bun 1.3.14 and pnpm 11.9.0:
pnpm run types: passed.pnpm run format: passed.pnpm run test --randomize --seed 12345: 1,318 passed, 11 skipped, 0 failed. The first run was blocked only by macOS refusing a nested sandbox; the complete rerun passed with the needed sandbox access.pnpm run test: 1,318 passed, 11 skipped, 0 failed.node --check scripts/run-windows-ci-tests.mjs: passed.git diff --check: passed.Risk and rollout
Test and CI configuration only. A stuck Windows test can now run up to 90 seconds longer, but the existing ten-minute shard timeout still bounds the job. Assertions and exit-code handling remain active. Hosted Windows CI must pass before merge. The separate lock fix in #494 is still needed.
Public disclosure review