Skip to content

ci: allow slower Windows integration tests - #509

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/windows-ci-test-timeout
Aug 17, 2026
Merged

ci: allow slower Windows integration tests#509
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/windows-ci-test-timeout

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Give Windows CI integration tests enough time to finish. In the failed main run, the API shard timed out while validating knowledge-base documents and preparing a managed credential home. The document test ran for about 58 seconds before reporting the existing 30-second timeout.

The separate multiscan failure in that run is already covered by #494. This PR does not duplicate that production fix.

Changes

  • Raise Bun's per-test timeout from 30 seconds to two minutes in the Windows shard runner.
  • Keep all seven shards, test selection, failure propagation, and the ten-minute workflow step timeout unchanged.
  • Leave the normal package test timeout and production code unchanged.

Testing

Using Bun 1.3.14 and pnpm 11.9.0:

  • Temporary subprocess harness: passed. It checks all seven timeout arguments, complete test-file assignment, single-shard selection, failed-child propagation, invalid shard rejection, and the unchanged package timeout. The timeout assertion failed before the change.
  • Focused API and multiscan tests: 6 passed, 0 failed.
  • pnpm run types: passed.
  • pnpm run format: passed.
  • pnpm run test --randomize --seed 12345: 1,318 passed, 11 skipped, 0 failed. The first run was blocked only by macOS refusing a nested sandbox; the complete rerun passed with the needed sandbox access.
  • pnpm run test: 1,318 passed, 11 skipped, 0 failed.
  • node --check scripts/run-windows-ci-tests.mjs: passed.
  • git diff --check: passed.

Risk and rollout

Test and CI configuration only. A stuck Windows test can now run up to 90 seconds longer, but the existing ten-minute shard timeout still bounds the job. Assertions and exit-code handling remain active. Hosted Windows CI must pass before merge. The separate lock fix in #494 is still needed.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review commit 80b4fce. Keep feedback public-safe and omit nonpublic task or report links.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 80b4fcefdd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@openai openai deleted a comment from chatgpt-codex-connector Bot Aug 17, 2026

Copy link
Copy Markdown
Collaborator Author

The Codex security review of commit 80b4fcefdd797cb504971c4425d22236892ab4f4 reported no security issues. The original automated comment was removed because it included an access-restricted report link. This summary preserves the review result without publishing that link.

@mldangelo-oai
mldangelo-oai marked this pull request as ready for review August 17, 2026 22:16
@mldangelo-oai
mldangelo-oai merged commit dc381a8 into main Aug 17, 2026
34 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/windows-ci-test-timeout branch August 17, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants