fix: image build#3
Conversation
|
Hi @pat-s |
|
I did a standard The fixes above were needed to get a build going in the first place (for the build stage). It would be easier to spot/reference if there would be an open build process for all the images, regardless of whether they are being stored in your own registry or on dockerhub and friends 🙂️ (PS: just as a side-note to all the image building approaches: most openanalytic images are quite out-of-date WRT to the base images and other deps. And include a lot of things which are not needed to get the app running. Example: in the repo I linked, I built |
| app.use(pinia) | ||
| app.use(i18nInstance) | ||
| app.use(abilitiesPlugin, caslAbility) | ||
| app.component('apexchart', VueApexCharts) |
There was a problem hiding this comment.
Since we are using Vue 3 (and vue3-apexcharts), the recommended way to register is app.use(VueApexCharts) (see https://apexcharts.com/docs/vue-charts/)
| "useDefineForClassFields": true, | ||
| "module": "ESNext", | ||
| "moduleResolution": "Node", | ||
| "moduleResolution": "bundler", |
There was a problem hiding this comment.
Ideally, in this case also "allowImportingTsExtensions": true should be used. See https://vite.dev/guide/performance.html#reduce-resolve-operations.
Ok, thanks for the quick reply. |
These patches are required to get the Dockerfile built (with
node:lts-alpine).See also:
Would like to switch back to the upstream source again, once fixed.