fix(live-proof): scroll browser targets into view best effort - #1202
Merged
Conversation
Scroll-into-view ran before the force-click fallback, so continuously animated targets — the Bay shoreline critters are exactly this — timed out at 15s and failed the step before the fallback could fire. Every bay UI demonstration skipped as a result. Scrolling is now bounded and non-fatal; the click or visibility wait still decides whether a step succeeded.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(live-proof): scroll browser targets into view best effort This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser live proofs could not demonstrate anything on animated pages. #1199 added
scrollIntoViewIfNeeded()for framing, but it ran before the force-click fallback and threw after a 15s timeout on targets that never stop moving — the OpenClaw Bay shoreline critters are precisely that case. Every bay UI plan therefore failed at its first click and skipped with "plan verified nothing that changed", which looked like a plan-quality problem and was actually this regression.Scrolling is now bounded (2s) and non-fatal; the click or visibility wait still decides whether the step succeeded, so the force-click fallback works again.
Validation
Recorded locally against the seeded Bay demo after the fix: all 9 plan steps completed, 24.7s, and the frames show the detail blade opening with canonical links and ordered job steps, then the finder resolving a reference. Before the fix the identical plan skipped at step 2.
pnpm buildclean; live-proof suite 39/39. Autoreview (Codex, gpt-5.6-sol, high): clean, "patch is correct (0.99)".