docs(mantis): clarify inline proof commands and activation - #140452
docs(mantis): clarify inline proof commands and activation#140452brokemac79 wants to merge 1 commit into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
@clawsweeper review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Codex review: blocked before merge. Reviewed September 6, 2026, 5:27 PM ET / 21:27 UTC. ClawSweeper reviewWhat this changesUpdates the Mantis guide with inline proof commands, deployment prerequisites, supported scenarios, and shared review time limits. Merge readiness⛔ Blocked before merge - 1 item remains The clarification remains useful and is absent from current main. No actionable defect was found; the expanded source excerpts address the earlier review concern without claiming hosted activation. Priority: P3 Review scores
Verification
How this fits togetherMantis supplies behavioral observations for OpenClaw reviews. ClawSweeper selects and assesses those observations, while separate workflows run the checks and manage cleanup. flowchart LR
A[Maintainer proof request] --> B[ClawSweeper review]
B --> C[Select supported checks]
C --> D[Deployed proof workflows]
D --> E[Bounded observations]
E --> F[Review decision]
D --> G[Producer cleanup]
Before merge
Agent review detailsSecurityNone. PR surfaceDocs +30. Total +30 across 1 file. View PR surface stats
Review metricsNone. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the command guidance conditional on coordinated deployment and preserve the distinction between observations, proof sufficiency, and merge readiness. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR changes documentation, and the outdated guidance is directly visible on fetched main. Is this the best way to solve the issue? Yes: updating the existing guide is a focused solution, and the conditional wording accurately separates the paired implementation from deployment. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 270762e51d65. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
What Problem This Solves
The Mantis page still calls command integration future work and lists automatic selection as an open question. That conflicts with the paired request-bound implementation in ClawSweeper #1425 and OpenClaw #138953.
Related: merged #138210. This follows @brokemac79's request and @obviyus's feedback to make useful proof available inside the original review.
Why This Change Was Made
Correct the operator-facing instructions without adding more changes to the producer PR. The producer already adds a detailed later section about isolation and observations; this separate, non-overlapping patch supplies command, activation and timing guidance.
User Impact
@clawsweeper mantisis not a typed dispatch command.@clawsweeper proofoverride and either/both supported scenario selections, with automatic current-head resolution.Evidence
Scope is one English Markdown page only. No runtime, tests, workflow, database/schema, navigation, generated/localized docs or
CHANGELOG.mdchanges.Documentation proof: compared live merged/current-main page blob
38b736cccb9cdb41d6cc79927888d87b802ef5adwith consumerd405f24703ad7a7fc1539d06304faefdd98ebe8dcommand parser/prompt/budget and producer72ace9d87d5002fed4828b811ecb4f01ca6284b1, plus both live PR bodies. An independent combined-patch audit found no contradictory claims or overlapping edits with the producer's later detailed section.Executed on Node 24.19.0 using the dependency-ready checkout's repository tooling against the exact edited page:
No new headings, internal links, config fences or navigation routes are introduced. Both external PR links were inspected live. English remains the source of truth; translations are generated in the separate docs publish repository.
Codex reviews are scoped-clean through P2, zero actionable findings: dirty review confidence 0.97; committed-branch review confidence 0.98 at
7f5e0d0b84e6ce5442b43b848acc67b0aff1351a, base1fde67b08a4e8426474a46acd9ea968e300f8872. Commands:python .agents/skills/autoreview/scripts/autoreview --mode local --max-priority P2 --prompt <paired source context>before commit, then--mode branch --base 1fde67b08a4e8426474a46acd9ea968e300f8872 --max-priority P2after commit. Full scanning and final source verification stayed enabled. Source/mirror trees and complete binary branch diff matched; no findings required edits.git merge-tree --write-tree <docs-head> 72ace9d87d5002fed4828b811ecb4f01ca6284b1also passed, proving the docs changes combine without conflict with the producer head.Risks and Rollout
Pinned consumer source verification
The first ClawSweeper review could not retrieve the companion repository's blobs. To make the cross-repository evidence inspectable here, the following excerpts were checked against the GitHub Contents API at exact consumer revision
d405f24703ad7a7fc1539d06304faefdd98ebe8d; every returned blob SHA matched the local Git object, not a stale web-search result.Command parser (blob
50a85f20dc72172815594384d4a2a4686250e01e):Its supported list is
["web-ui-chat-proof", "telegram-bot-e2e-proof"];selection === "auto"returns both as available options. Admission setsconst scenarioId = match[1] ?? "auto"andconst headSha = match[2] ?? input.currentHeadSha, rejecting a supplied SHA that differs from the current PR head. The review prompt says to select useful supported checks in auto mode; explicit mode says to attempt each requested supported check and explain unavailable/inconclusive selections. Both use observations in that review's final decision and explicitly forbid enqueueing another review.Shared ceiling (blob
161fd310c29f66220c8d4c40078fde0855736df3):Original review bound (blob
733f4a2f899aa5754d2c293baa0a62b3cf157b13):The worker defines
reviewDeadline = Date.now() + options.timeoutMsonce and usesAbortSignal.timeout(remainingProofMs)for proof. Default review timeout (blob84278c4602d9fdaabfca98a9b162f11337264aa0) isDEFAULT_REVIEW_CODEX_TIMEOUT_MS = 1_200_000. Thus immediate proof has at most1_200_000 - 90_000 = 1_110_000ms, or 18m30s, less elapsed analysis. These exact-source checks resolve the review's source-access question; they do not claim deployment.This validates prose/source accuracy and MDX/formatting, not hosted activation, live Telegram or end-to-end latency. It must remain clear that the paired workflows/runtime need deployment. The existing producer PR retains the detailed execution boundaries; neither docs PR is a deployment or merge authorization.
Release-note context: clarify how selective inline proof is requested, bounded and activated.