chore(deps): refresh Go toolchain and archive dependencies - #168
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 5, 2026, 3:32 PM ET / 19:32 UTC. ClawSweeper reviewWhat this changesUpdates Slacrawl’s preferred Go toolchain, container build, archive dependencies, and secret scanner, with matching contributor documentation and release notes. Merge readiness✅ Ready for maintainer review Keep open: this is a focused maintenance update that current main does not contain. No actionable patch defect was found, and the earlier Go minimum-version concern does not apply to the current head. Likely related people: steipete and Vincent Koc are routing candidates based on prior dependency and workflow work; exact source-line attribution remains unverified. Priority: P3 Review scores
Verification
How this fits togetherSlacrawl imports Slack data into a local SQLite archive and exposes it through search, terminal views, and Git-backed sharing. These dependency and build updates affect the executable supporting those existing workflows. flowchart LR
A[Go toolchain and dependencies] --> B[Slacrawl executable]
C[Slack export] --> B
B --> D[Local SQLite archive]
D --> E[Search and terminal views]
D --> F[Git archive sharing]
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Retain the focused dependency refresh while preserving the documented Go minimum and existing archive formats. Do we have a high-confidence way to reproduce the issue? Not applicable: this maintenance PR does not report a remaining application bug; supplied verification exercises the affected archive and terminal workflows. Is this the best way to solve the issue? Yes: updating existing dependency selections and matching documentation is a narrow approach, and the current patch preserves the supported Go minimum. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against b9ff7d91485f. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (7 earlier review cycles)
|
|
Maintainer verification at
The fresh dependency audit found no stale module in the built CLI except libc 1.75.6, intentionally retained as SQLite requires. Other available module upgrades are outside the built CLI. Action pins and Cloudsmith CLI are current. Prepared for squash merge; no release, tag, or publication was performed. |
Refresh the archive and build dependencies to Go 1.27.1, Dockerfile frontend 1.27, CrawlKit 0.14.9, go-runewidth 0.0.29, SQLite driver 1.58.0 (SQLite 3.53.4), and TruffleHog 3.97.4. The Docker builder uses the matching official tag and digest. Complete the Unreleased notes, including the Cloudsmith CLI 1.26.0 update already on main.
The supported Go minimum stays at 1.27.0; a toolchain directive prefers 1.27.1. SQLite's required libc stays at 1.75.6 and its Linux OFD locking remains opt-in. Slacrawl owns its snapshot decoder, so the CrawlKit refresh is recorded as maintenance rather than claiming the upstream decoder fixes as new Slacrawl behavior.
Validation on final head
711934d63b4aa49cc0f0afee4452e7f5faa21a31:GOWORK=off GOMAXPROCS=2 GOFLAGS=-p=2 make check: module verification/tidy, formatting, vet, vulnerability and dead-code checks, full tests, stock CLI smoke, and four-target GoReleaser snapshot.qexited successfully.The earlier candidate also passed Go 1.27.0 store/CLI tests and real CLI import/search/re-import proof, plus AWS/Linux full checks and a Docker build/container smoke. CI validates the Docker build again on the final head. No real Slack data or credentials were used in this session's proof.