Replace 'guest' role with 'user-light' role#859
Open
LetsDrinkSomeTea wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the v4.0 External IDP documentation to use the correct OpenCloud role name (user-light) instead of the outdated guest, aligning the sample OIDC role mappings with current Proxy configuration expectations.
Changes:
- Replaced
role_name: guestwithrole_name: user-lightin the role mapping example. - Replaced
role_name: guestwithrole_name: user-lightin the documented defaultrole_mapping.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
docs/_static/env-vars/proxy_readme.md:254
- In the default
role_mappingexample,claim_valueis spelledopencloudcloudGuest(double “cloud”). This likely should beopencloudGuestto match theproxy.yamlreference and other docs; otherwise readers may copy an invalid claim value.
- role_name: user-light
claim_value: opencloudcloudGuest
Comment on lines
106
to
110
| claim_value: mySpaceAdminRole | ||
| - role_name: user | ||
| claim_value: myUserRole | ||
| - role_name: guest | ||
| - role_name: user-light | ||
| claim_value: myGuestRole |
Comment on lines
96
to
101
| - role_name: spaceadmin | ||
| claim_value: mySpaceAdminRole | ||
| - role_name: user | ||
| claim_value: myUserRole | ||
| - role_name: guest | ||
| - role_name: user-light | ||
| claim_value: myGuestRole |
Comment on lines
221
to
225
| claim_value: mySpaceAdminRole | ||
| - role_name: user | ||
| claim_value: myUserRole | ||
| - role_name: guest | ||
| - role_name: user-light | ||
| claim_value: myGuestRole |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed old missleading documentation. As seen in https://docs.opencloud.eu/de/docs/dev/server/services/proxy/yaml-config the correct role is
user-lightinstead of guest.