PF-1.22: fixes for ipv4_guev1_decap_and_hashing_test#5441
PF-1.22: fixes for ipv4_guev1_decap_and_hashing_test#5441davinsingh-arista wants to merge 1 commit into
Conversation
Fix 1: Today, the test successfully configures BGP and applies a routing policy ALLOW, which should allow all received routes. However, the test never defines this routing policy ALLOW, so all received routes are rejected. (Ultimately, this causes the inner packet to be dropped since there is no route for it) Fix 2: Flow-9 and Flow-10 were failing because they happened to be load balancing with a distribution of 200,000/800,000. This distribution depends on the random load balancing polynomial on the device, but it would still be better to increase the number of UDP src ports to increase the entropy and get the test to pass more consistently.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses stability issues in the ipv4_guev1_decap_and_hashing_test. It ensures that necessary routing policies are defined before BGP reference and increases the entropy of generated traffic flows to prevent intermittent failures caused by uneven load balancing distribution. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances load balancing entropy in the IPv4 GUEv1 decapsulation tests by increasing the UDP source port increment count and updating the base port constant. It also ensures that the routing policy is defined and applied before BGP references it to prevent route rejection. I have no feedback to provide.
3 participants
Fix 1:
Today, the test successfully configures BGP and applies a routing policy ALLOW, which should allow all received routes. However, the test never defines this routing policy ALLOW, so all received routes are rejected. (Ultimately, this causes the inner packet to be dropped since there is no route for it). The fix is adding a call to ConfigureCommonBGPPolicies and configuring the ALLOW policy.
Fix 2:
Flow-9 and Flow-10 were failing because they happened to be load balancing with a distribution of 200,000/800,000. This distribution depends on the random load balancing polynomial on the device, and since today the test only sends packets with 10 UDP source ports, there is not enough entropy. It would be better to increase the number of UDP src ports to even the distribution and get the test to pass more consistently.
I've attached the log from a passing test run:
pf-1_22.txt