Adding IPv6 outer header usecases for UDP and GRE encaps#5470
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the test suite coverage for MPLS over GRE/UDP encapsulation and decapsulation by introducing support for IPv6 outer headers. The changes include detailed test procedures, configuration examples, and telemetry validation steps for multiple scenarios, including MACsec-encrypted links, QoS-aware forwarding, and high-scale decapsulation performance. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds several new test plans (PF-1.25.v6, PF-1.17.6, PF-1.17.v6, PF-1.18.v6, PF-1.20.v6, and PF-1.19.v6) focused on validating MPLS static LSPs and various encapsulation/decapsulation methods (GRE, UDP, GUE) using IPv6, covering MACsec, QoS, and scale scenarios. Feedback indicates that several Canonical OC configurations are incomplete, specifically missing the 'rules' container or detailed match/action criteria for policy forwarding. Additionally, the 'decapsulate-mpls-in-udp' leaf needs to be corrected to a boolean type and added where missing to properly trigger decapsulation.
…test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…EADME.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ets with IPv4 and IPv6 payload
…hub.com/nkhambal/featureprofiles into mpls_encap_decap_with_ipv6_outer_header
This PR adds test case coverage for using IPv6 outer header for MPLSoverGRE and MPLSoverUDP encap and decap test cases, in addition to IPv4 outer header