Skip to content

Adding gribi test cases for higher IPv4 and IPv6 tunnel scale#5474

Open
nkhambal wants to merge 2 commits into
openconfig:mainfrom
nkhambal:gribi_new_scale_test_cases
Open

Adding gribi test cases for higher IPv4 and IPv6 tunnel scale#5474
nkhambal wants to merge 2 commits into
openconfig:mainfrom
nkhambal:gribi_new_scale_test_cases

Conversation

@nkhambal
Copy link
Copy Markdown

This PR adds 2 new scale profiles. First profile is for 32K IPv4 tunnels with 16 NHs per NHG and 26K IPv6 tunnels with 16 NHs per NHG. Both profiles use 1024 VRFs.

@nkhambal nkhambal requested a review from a team as a code owner May 15, 2026 08:56
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces two new scale profiles to the gRIBI testing suite to validate higher tunnel density and ECMP configurations. The changes include defining the necessary parameters and validation steps for testing 32K IPv4 and 26K IPv6 tunnels, ensuring the control plane can handle increased scale across multiple VRFs.

Highlights

  • New Scale Profiles: Added two new test profiles (Profile 6 and 7) to support higher IPv4 and IPv6 tunnel scaling, featuring 32K and 26K Next Hops respectively across 1024 VRFs.
  • Documentation Updates: Updated the README to include parameters for the new profiles, validation procedures, and expanded OpenConfig path requirements for UDPv4 encapsulation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Profiles 6 and 7 to the MPLS-in-UDP scale tests, adding documentation for multi-VRF scaling with 16-way ECMP using IPv4 and IPv6 outer headers. It includes new scale parameters, detailed test procedures, and additional OpenConfig paths for UDP-v4 encapsulation state. The review feedback correctly identifies that the chosen IPv4 base addresses for scaling (192.0.2.1 and 203.0.113.1) will exceed the allowed RFC 5737 /24 blocks defined in the style guide when incremented to the target scale; larger blocks such as 100.64.0.0/10 are recommended.

Comment thread feature/gribi/mpls_in_udp/otg_tests/mpls_in_udp_scale/README.md Outdated
Comment thread feature/gribi/mpls_in_udp/otg_tests/mpls_in_udp_scale/README.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants