Adding gribi test cases for higher IPv4 and IPv6 tunnel scale#5474
Adding gribi test cases for higher IPv4 and IPv6 tunnel scale#5474nkhambal wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces two new scale profiles to the gRIBI testing suite to validate higher tunnel density and ECMP configurations. The changes include defining the necessary parameters and validation steps for testing 32K IPv4 and 26K IPv6 tunnels, ensuring the control plane can handle increased scale across multiple VRFs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces Profiles 6 and 7 to the MPLS-in-UDP scale tests, adding documentation for multi-VRF scaling with 16-way ECMP using IPv4 and IPv6 outer headers. It includes new scale parameters, detailed test procedures, and additional OpenConfig paths for UDP-v4 encapsulation state. The review feedback correctly identifies that the chosen IPv4 base addresses for scaling (192.0.2.1 and 203.0.113.1) will exceed the allowed RFC 5737 /24 blocks defined in the style guide when incremented to the target scale; larger blocks such as 100.64.0.0/10 are recommended.
This PR adds 2 new scale profiles. First profile is for 32K IPv4 tunnels with 16 NHs per NHG and 26K IPv6 tunnels with 16 NHs per NHG. Both profiles use 1024 VRFs.