feat: add Competency Tree on the Competency Management page - #3218
feat: add Competency Tree on the Competency Management page#3218AShatsila wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Thanks for the pull request, @AShatsila! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
Adds a new read-only Competency Management page at
/taxonomy/:taxonomyId/competencies. It shows a competency taxonomy's tags as a nested expand/collapse tree (taxonomy name → groups → sub-competencies), with each row's Competency ID (external_id) displayed next to it. The page is fully read-only: no editing of names or IDs, no add/edit/delete affordances anywhere, and no backend/API/data-layer changes.This is a new page, so it doesn't change behavior for any existing role. It's intended for Platform Administrators who need to browse a taxonomy's competencies by their stable Competency ID before applying competency criteria elsewhere.
Supporting information
Testing instructions
ENABLE_TAGGING_TAXONOMY_PAGESfeature flag.external_idset./taxonomy/:taxonomyId/competenciesfor that taxonomy.external_idshows it as a badge, and the tag without one shows no badge (not the literal text "undefined" or "null")./taxonomy/:taxonomyIdpage (tag editing) and confirm it's unaffected — same table, same columns, same zebra striping as before.Other information
src/taxonomy/tree-table/) that the editable taxonomy detail page uses. That shell is built around an HTML<table>/TanStack Table, which can't express per-row gaps or nested "card" grouping without hacky workarounds (<tr>can't takemargin, and abox-shadow-based border approach bled across row boundaries). Since this page needs neither the shared shell's editing machinery nor its tabular semantics, it renders its own lightweight<ul>/<li>tree instead, reusing only the taxonomy-tag-to-tree data shaping (TagTree) from the existing tag-list feature.#006DAA) doesn't correspond to any existing Paragon semantic color variant in this app's theme (variant="info"resolves to teal) - it's retinted via a page-scoped CSS custom-property override on top of the realBadgecomponent. Flagging per the standing internal reminder to surface anything not natively available in Paragon.aria-labelsince there's no table header for screen readers to associate it with.Best Practices Checklist
Any new files are using TypeScript (
.ts,.tsx).Avoid
propTypesanddefaultPropsin any new or modified code.Tests should use the helpers in
src/testUtils.tsx(specificallyinitializeMocks)Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
Use React Query to load data from REST APIs. See any
apiHooks.tsin this repo for examples.All new i18n messages in
messages.tsfiles have adescriptionfor translators to use.Avoid using
../in import paths. To import from parent folders, use@src.Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'