feat!: upgrade to frontend-base 2.0 - #129
Merged
Merged
Conversation
Take the peer dependency to the 2.0 prerelease line and source IntlShape from frontend-base, which now re-exports it, rather than from react-intl, a package this repository does not declare and only resolves by hoisting. The app bundles no config, so App.defaultConfig has nothing to hold here. BREAKING CHANGE: requires @openedx/frontend-base ^2.0.0-alpha.4. Closes openedx#128 Co-Authored-By: Claude <noreply@anthropic.com>
Mechanical npm run lint:fix for a rule frontend-base 2.0 enables. Co-Authored-By: Claude <noreply@anthropic.com>
|
🎉 This PR is included in version 4.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Takes the
@openedx/frontend-basepeer dependency from^1.0.0 || 0.0.0-devto^2.0.0-alpha.4 || 0.0.0-dev, the prerelease line published to thealphadist-tag, and adopts what 2.0 brings. Part of openedx/frontend-base#299.Of the four changes since 1.0, two are no-ops here. Nothing imports the
injectIntlorintlShapeshims that the react-intl v10 bump dropped, and the app bundles noconfig, soApp.defaultConfighas nothing to hold. The one real adoption issrc/Notification/tours/constants.ts, which importedIntlShapefromreact-intl- a package this repository does not declare as a dependency and which only resolved through hoisting. 2.0 re-exports the type, so it now comes from@openedx/frontend-baselike every other intl import in the app.The shared ESLint config now requires semicolons rather than commas between TypeScript type members. That churn is
npm run lint:fixoutput and lands in its own commit, so it stays out of the upgrade's diff.Closes #128
LLM usage notice
Built with assistance from Claude.