Skip to content

docs: add ADR for mapping pathway items to fulfillment - #763

Open
Agrendalath wants to merge 2 commits into
openedx:mainfrom
open-craft:agrendalath/pathways-adr-item-fulfillment
Open

docs: add ADR for mapping pathway items to fulfillment#763
Agrendalath wants to merge 2 commits into
openedx:mainfrom
open-craft:agrendalath/pathways-adr-item-fulfillment

Conversation

@Agrendalath

@Agrendalath Agrendalath commented Aug 20, 2026

Copy link
Copy Markdown
Member

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Agrendalath!

This repository is currently maintained by @axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Aug 20, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Aug 20, 2026
@Agrendalath Agrendalath self-assigned this Aug 20, 2026
@ormsbee

ormsbee commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Reading this does make me think of a weird edge case that will probably require an async task, which is:

What happens when the following sequence of events happens:

  1. A learner successfully completes Course Run A, which does not count for anything in the Pathway.
  2. The learner enrolls in the Pathway.
  3. The author then edits a Pathway Item so that Course Run A does fulfill it.

This slips by both our typical Item satisfaction checks:

  • The one-time check on Pathway enrollment that goes though everything the student has already done.
  • The on-passing event check that we can catch when they pass the course run, which we'd then check against all active pathway item fulfillment criteria.

So the only thing I can think of to address this automatically would be to fire off an async task that goes through all the students currently enrolled in that Pathway whenever changes to a Pathway Item are published, and give retroactive Pathway Item credit for anything new that was added to that Item.

@Agrendalath

Copy link
Copy Markdown
Member Author

@ormsbee, @bradenmacdonald, I described evaluation scenarios in a1ee30d.

@ormsbee ormsbee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to merge this tomorrow afternoon (1 week after it was initially opened), unless anyone has objections.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready to Merge in Contributions Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready to Merge

Development

Successfully merging this pull request may close these issues.

5 participants