Bump rubocop from 1.84.2 to 1.86.0 to 1.86.1#14128
Open
dependabot[bot] wants to merge 14 commits intomasterfrom
Open
Bump rubocop from 1.84.2 to 1.86.0 to 1.86.1#14128dependabot[bot] wants to merge 14 commits intomasterfrom
dependabot[bot] wants to merge 14 commits intomasterfrom
Conversation
dependabot-pr-automation
Bot
moved this from All the things 💤
to Code review 🔎
in OFN Delivery board
Contributor
Author
|
A newer version of rubocop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.84.2 to 1.86.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.84.2...v1.86.0) --- updated-dependencies: - dependency-name: rubocop dependency-version: 1.86.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
mkllnk
changed the title
mkllnk
force-pushed
the
dependabot/bundler/rubocop-1.86.0
branch
from
094fad5 to
c657200
Compare
mkllnk
approved these changes
Apr 24, 2026
mkllnk
force-pushed
the
dependabot/bundler/rubocop-1.86.0
branch
from
c657200 to
3e31402
Compare
The patched class does not exist anymore.
I made quite a few changes here to appease Rubocop, good changes. But
there were some indentation suggestions which would make reading the
code harder. One example:
```
--- a/app/models/spree/taxon.rb
+++ b/app/models/spree/taxon.rb
@@ -35,8 +35,8 @@ module Spree
taxons
.pluck('spree_taxons.id, enterprises.id AS enterprise_id')
.each_with_object({}) do |(taxon_id, enterprise_id), collection|
- collection[enterprise_id.to_i] ||= Set.new
- collection[enterprise_id.to_i] << taxon_id
+ collection[enterprise_id.to_i] ||= Set.new
+ collection[enterprise_id.to_i] << taxon_id
end
end
```
Ideally, we wouldn't mix multi-line method chains with blocks as
argument. So I added this to the todo file for now.
mkllnk
force-pushed
the
dependabot/bundler/rubocop-1.86.0
branch
from
3e31402 to
c809709
Compare
I reviewed all `respond_with` calls and none passed on an `action` option.
mkllnk
approved these changes
Apr 24, 2026
Member
|
This was a bit of a rabbit hole. I'm not sure if it's good to finally clean up some ancient code, triggered and helped by rubocop or if it's a waste of time and we should just regenerate the todo when the gem is bumped. 🤷 I find this cathartic ... until I have to revise my commits a dozen times. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 1.84.2 to 1.86.0.
Release notes
Sourced from rubocop's releases.
... (truncated)
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
2c1b30aCut 1.86d96701aUpdate Changelog9b019c7[Fix rubocop#14916] Fix false positive for `Layout/MultilineMethodCallIndenta...a49271dFix incorrect autocorrection forStyle/IfUnlessModifierwhen multipleif/...8d25311Document MaxFilesInCache: false option for disabling cache pruning12c7d39Detect constant reassignment after class/module definition in `Lint/ConstantR...fbf175cAllow disabling cache cleanup3fcae5d[Fix #14961] AddAllowedParentClassesoption toStyle/EmptyClassDefinition4eba3e6Memoize forwarded arg lookups in ArgumentsForwardingfc300c7[Fix #10822] Don't cache if there are warningsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)