Skip to content

Huge map update: Re-make of the terrain of multiple maps for better gameplay#4139

Open
RickD004 wants to merge 2 commits into
openfrontio:mainfrom
RickD004:LargeMapOverhaul
Open

Huge map update: Re-make of the terrain of multiple maps for better gameplay#4139
RickD004 wants to merge 2 commits into
openfrontio:mainfrom
RickD004:LargeMapOverhaul

Conversation

@RickD004
Copy link
Copy Markdown
Contributor

@RickD004 RickD004 commented Jun 3, 2026

Resolves #4099

Description:

Remake the terrain of various maps with green gaps in their terrain, example below (strait of gibraltar)
image

Why?

In maps with continuous brown and white terrain, it is easier for a player to defend against an attacker, as these types of terrains slow down troops. However in maps with green gaps like the one in the example, the troops will just rush in the green gaps and surround all the white terrain, instantly absorbing them, which makes the terrain mostly useless against defending.

I believe that this new type of terrain (using proper elevation data instead of "hillshade like the ones used in these maps) is better for gameplay as it adds more complexity to attacks and defense, and also brings diversity to spawns, as right now these maps have functionally all-green terrain all across them

I also changed the coastline of some maps that had them very pixelated. This sometimes caused some rivers to dissapear and some islands to be merged into blobs.

I kept the rivers of all maps even if slightly updated, to not change naval gameplay.

The maps changed were:

Black Sea (terrain and coastline)
Gateway to the Atlantic (terrain only)
Between 2 seas (terrain only)
Iceland (terrain and coastline)
East Asia (terrain only)
Falklands (terrain and coastline)
Halkidiki (terrain only)
Strait of Gibraltar (terrain and coastline)
Italia (terrain and coastline)
Japan (terrain only)
Two Lakes (terrain only)

Captura de pantalla 2026-06-02 213132 Captura de pantalla 2026-06-02 213251 Captura de pantalla 2026-06-02 213336 Captura de pantalla 2026-06-02 231736 Captura de pantalla 2026-06-02 231804 Captura de pantalla 2026-06-02 212309 Captura de pantalla 2026-06-02 212531 Captura de pantalla 2026-06-02 212709 Captura de pantalla 2026-06-02 212839 Captura de pantalla 2026-06-02 212937 Captura de pantalla 2026-06-02 213028

Terrain sources from NASA and OpenTopography, both already credited in CREDITS

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d0010dfa-cf22-4fdb-bc3f-352aa5a49cf4

📥 Commits

Reviewing files that changed from the base of the PR and between 217aaca and d41cf0a.

⛔ Files ignored due to path filters (3)
  • resources/maps/blacksea/map.bin is excluded by !**/*.bin
  • resources/maps/blacksea/map16x.bin is excluded by !**/*.bin
  • resources/maps/blacksea/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (2)
  • resources/maps/blacksea/manifest.json
  • resources/maps/blacksea/thumbnail.webp
✅ Files skipped from review due to trivial changes (1)
  • resources/maps/blacksea/manifest.json

Walkthrough

Nine map manifest files have updated num_land_tiles values across resolution tiers (map, map16x, map4x); all other manifest fields, including width and height, remain unchanged.

Changes

Map Terrain Tile Count Updates

Layer / File(s) Summary
Black Sea terrain update
resources/maps/blacksea/manifest.json
Land tile counts updated for map, map16x, and map4x scales with new values while preserving dimensions and nation data.
Falkland Islands terrain update
resources/maps/falklandislands/manifest.json
Tile counts revised for map, map16x, and map4x scales; map dimensions and structure unchanged.
Gateway to the Atlantic terrain update
resources/maps/gatewaytotheatlantic/manifest.json
map and map4x num_land_tiles adjusted; dimensions unchanged.
Halkidiki terrain update
resources/maps/halkidiki/manifest.json
map and map4x num_land_tiles updated; other fields untouched.
Iceland terrain update
resources/maps/iceland/manifest.json
Tile counts refreshed across map, map16x, and map4x; width/height unchanged.
Italia terrain update
resources/maps/italia/manifest.json
num_land_tiles updated for map, map16x, and map4x; dimensions preserved.
Japan terrain update
resources/maps/japan/manifest.json
Tile counts revised for map, map16x, and map4x; overall JSON structure unchanged.
Strait of Gibraltar terrain update
resources/maps/straitofgibraltar/manifest.json
num_land_tiles adjusted across map, map16x, and map4x; width/height unchanged.
Two Lakes terrain update
resources/maps/twolakes/manifest.json
Tile counts updated for map, map16x, and map4x scales; manifest structure preserved.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

bypass-pr-check

Suggested reviewers

  • evanpelle
  • FloPinguin

Poem

🗺️ Nine maps had gaps that caused a frown,
Now tiles are counted and brown fills the town.
Numbers updated across scale and map,
Dimensions stay steady — no structural gap.
Gameplay smoother, defenders clap! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: remaking terrain on multiple maps to improve gameplay, which directly matches the primary objective of the PR.
Description check ✅ Passed The description provides detailed context about terrain improvements, gameplay rationale, specific maps changed, and references the linked issue #4099.
Linked Issues check ✅ Passed The PR successfully implements the objectives from #4099: terrain is remade on multiple listed maps (Black Sea, Gateway to the Atlantic, Between 2 seas, Iceland, East Asia, Falklands, Halkidiki, Strait of Gibraltar, Italia, Japan, Two Lakes) using proper elevation data to eliminate green gaps and improve defensive gameplay.
Out of Scope Changes check ✅ Passed All changes are manifest file updates reflecting new num_land_tiles values for the remade maps, which are direct results of terrain changes and within scope of the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RickD004
Copy link
Copy Markdown
Contributor Author

RickD004 commented Jun 3, 2026

Rabbit didnt list Between Two Seas and East Asia because their tile count remained unchanged and as such skipped them from the table, but their terrain was changed too

@iiamlewis iiamlewis added this to the v32 milestone Jun 4, 2026
@iiamlewis iiamlewis added the approved Approved for a PR, if you assigned to the issue. label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved for a PR, if you assigned to the issue.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

Fix green gaps in terrain of various maps

2 participants