Move Java EE 8 servlet update into separate recipe#1170
Merged
Conversation
timtebeek
approved these changes
Jul 17, 2026
timtebeek
left a comment
timtebeek
left a comment
Member
There was a problem hiding this comment.
Thanks once again! No idea why these were ever in a different order; this indeed makes more sense.
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR moves the Java EE 8 Servlet update to 3.x into a separate recipe. This new recipe is then referenced by the
org.openrewrite.java.migrate.javaee8recipe list. Also, the order of the recipes in this list was adjusted to ensure thatorg.openrewrite.java.migrate.javaee7recipe is called first.What's your motivation?
Splitting this recipe out allows for users to call it individually, without invoking the full Java EE 8 recipe list. Moving the Java EE 7 recipes to the top of the Java EE 8 list ensures that updates are made in the correct order for users migrating across multiple Java EE levels.
Anyone you would like to review specifically?
@timtebeek
Checklist