Update NoGuavaRefaster expected output for upstream static-import change#1171
Merged
Merged
Conversation
The 2026-07-20 openrewrite/rewrite snapshot changed NoGuavaRefaster so that Preconditions.checkNotNull(obj, description) now migrates to requireNonNull(obj, valueOf(description)) with a static import of java.lang.String.valueOf, rather than String.valueOf(description). Aligns the expected output in preconditionsCheckNotNullToObjectsRequireNonNullTwoArgumentsSecondObject with current behavior. CI: https://github.com/openrewrite/rewrite-migrate-java/actions/runs/29769956822
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
The 2026-07-20
openrewrite/rewritesnapshot changedNoGuavaRefasterso that:now migrates to
requireNonNull(obj, valueOf(description))with a static import ofjava.lang.String.valueOf, instead ofrequireNonNull(obj, String.valueOf(description)).This updates the expected output of
preconditionsCheckNotNullToObjectsRequireNonNullTwoArgumentsSecondObjectto match current behavior, unblocking the scheduled CI.Why?
1 test failed. Reproduced locally against the current snapshot.