JavaScript: integTest#8079
Draft
greg-at-moderne wants to merge 7 commits into
Draft
Conversation
The default JS RPC server discards its stderr, so a startup crash in CI (exit code 1 before any request) left no diagnostic trail. Honor a rewrite.rpc.logDir system property (or REWRITE_RPC_LOG_DIR env var) to redirect each server's output to a file, point the integTest task at build/rpc-logs, and upload it as a CI artifact.
The RPC launcher only skipped npx --package for versions ending in -SNAPSHOT. On CI the SNAPSHOT token is replaced by a commit timestamp (e.g. 0.1.0-20260624-090742), so npx tried to fetch an unpublished version and failed with npm ETARGET, killing every RPC process and cascading across the integTest suite. Treat the dated-snapshot form as locally linked too.
# Conflicts: # rewrite-javascript/src/main/java/org/openrewrite/javascript/rpc/JavaScriptRewriteRpc.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not planning to merge this.