Fix provided deps resolution for maven#8306
Conversation
timtebeek
left a comment
There was a problem hiding this comment.
Looks reasonable to me already; what made you mark this as draft still?
|
@timtebeek AI helped creating this... It seems convincing at first but I learned my lesson using it with Gradle and started adding tests myself and realized that this is probably wrong. It is somewhat confusing that there are a number of scopes but only 3 types of classpaths: compile, rutnime, test. For scopes matching the classpath everything is obvious but for scope such as provided none of the other scopes can affect it seems yet it leaks into Compile and Test classpaths... Does it mean we should add a provided dependency under the compile and test scopes. If yes then table below that Claude has created: Should be: I also don't like that it changed I'm still working on this... I'm leaning toward reverting what it did for I should see how this is done in the rewrite maven plugin... |
|
@timtebeek I started looking at this because saw a direct runtime dependency in the provided scope of resolved dependencies in |
|
The test failure is related to downloading metadata from maven central. The download request gets a 401 response. The test UpgradeDependencyVersionTest > badManagedVersion(). |
Currently the direct runtime dependency is placed o the provided scope list of resolved dependencies which is not right. The direct (root) dependencies should not follow transitive dependency scope matrix when placed into scope buckets.