Performance Benchmark Rest Apis - #202
Open
rishabh6788 wants to merge 6 commits into
Open
Conversation
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Signed-off-by: Rishabh Singh <sngri@amazon.com>
rishabh6788
marked this pull request as ready for review
September 5, 2024 04:46
rishabh6788
requested review from
DandyDeveloper,
TheAlgo,
gaiksaya,
peterzhuamazon and
prudhvigodithi
as code owners
September 5, 2024 04:46
rishabh6788
force-pushed
the
main
branch
6 times, most recently
from
September 5, 2024 05:02
e65e0a8 to
e1ba7ab
Compare
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Author
|
@peterzhuamazon @gaiksaya Please provide review comments and feedback whenever you can. |
peterzhuamazon
left a comment
peterzhuamazon
left a comment
Member
There was a problem hiding this comment.
Generally good on the 1st pass.
In offline conversation, I raise the question of having a limit set in API Gateway so that to prevent potential spamming on the API calls.
Thanks.
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Author
Added throttling rule to api. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces following rest apis to help opensource opensearch-project contributors submit ad-hoc benchmark runs on our jenkins infra. They do not need to log-in to the jenkins to submit the job as long as they are authorized using github teams.
submitBenchmarkRun: Rest api to submit ad-hoc benchmark using artifact tarball. Will re-use jenkin's benchmark-pull-request job to run benchmark.submitBenchmarkEndpointRun: Rest api to submit ad-hoc benchmark against user's cluster endpoint. Will use benchmark-test-endpoint to run benchmark.See detailed design in opensearch-project/opensearch-build#4231
Issues Resolved
opensearch-project/opensearch-build#4788
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.