HYPERFLEET-1143 - chore: Remove kind from list schemas#6
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis release updates HyperFleet API specification to version 1.0.22. It standardizes error responses across all endpoints to use RFC 9457 Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@schemas/template/openapi.yaml`:
- Around line 1969-1989: The Spectral lint flags ForbiddenDetails and
ForbiddenResponse as unused; update the upstream TypeSpec definitions so these
schemas are actually referenced by 403 responses or remove them from the core
models and regenerate the OpenAPI: either wire
ForbiddenDetails/ForbiddenResponse into the appropriate service operation
responses in the .tsp files (attach ForbiddenResponse as the 403 response for
relevant operations) or delete the corresponding model declarations in the
TypeSpec sources and run the generator to produce a spec without these unused
components, then re-run CI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 263b9b9e-cbea-4bd4-bb59-4c6a8a782968
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
CHANGELOG.mdmain.tspschemas/template/openapi.yamlschemas/template/swagger.yaml
Description:
Summary
mainand regenerate schemaskindproperty is removed from all list response schemas (ClusterList,NodePoolList,AdapterStatusList,ResourceList,WIFConfigList) — inherited from core spec HYPERFLEET-1143Context
The template's npm dependency on the core spec (
hyperfleet-api-spec#main) was stale — pinned to commit 78199f6 (HYPERFLEET-1103 repo split). This refresh picks up 4 core releases:core/andshared/directorieskindremoved from list response schemasThe large schema diff is primarily from HYPERFLEET-993 (error models rewrite) and HYPERFLEET-1143 (kind removal).
Changes
main.tsp— version bump 1.0.21 → 1.0.22CHANGELOG.md— added 1.0.22 entrypackage-lock.json— refreshed core spec dependencyschemas/template/openapi.yaml— regeneratedschemas/template/swagger.yaml— regeneratedTest plan
spectral lintpasses (1 pre-existing warning)kindabsent from all list schemaskindstill present on individual resource schemas