Skip to content

chore: replace bingo with Go 1.24 tool directives#203

Open
kuudori wants to merge 1 commit into
openshift-hyperfleet:mainfrom
kuudori:remove-bingo
Open

chore: replace bingo with Go 1.24 tool directives#203
kuudori wants to merge 1 commit into
openshift-hyperfleet:mainfrom
kuudori:remove-bingo

Conversation

@kuudori
Copy link
Copy Markdown
Contributor

@kuudori kuudori commented Jun 3, 2026

Remove bingo tool management in favor of native tool directives in go.mod (Go 1.24+). Tool versions are pinned in go.mod/go.sum and resolved via go tool <name>.

Pinned versions (unchanged from bingo):

  • golangci-lint v2.7.0
  • oapi-codegen v2.6.0
  • mockgen v0.6.0
  • gotestsum v1.13.0

Summary

  • HYPERFLEET-XXX

Test Plan

  • Unit tests added/updated
  • make test-all passes
  • make lint passes
  • Helm chart changes validated with make test-helm (if applicable)
  • Deployed to a development cluster and verified (if Helm/config changes)
  • E2E tests passed (if cross-component or major changes)

@openshift-ci openshift-ci Bot requested review from Mischulee and mbrudnoy June 3, 2026 20:12
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign crizzo71 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8386a69c-7ca8-48ae-9cab-91d782d20f47

📥 Commits

Reviewing files that changed from the base of the PR and between adda43a and a827b17.

⛔ Files ignored due to path filters (5)
  • .bingo/golangci-lint.sum is excluded by !**/*.sum
  • .bingo/gotestsum.sum is excluded by !**/*.sum
  • .bingo/mockgen.sum is excluded by !**/*.sum
  • .bingo/oapi-codegen.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum, !**/go.sum
📒 Files selected for processing (20)
  • .bingo/.gitignore
  • .bingo/README.md
  • .bingo/Variables.mk
  • .bingo/go.mod
  • .bingo/golangci-lint.mod
  • .bingo/gotestsum.mod
  • .bingo/mockgen.mod
  • .bingo/oapi-codegen.mod
  • .bingo/variables.env
  • CLAUDE.md
  • Dockerfile
  • Makefile
  • docs/development.md
  • go.mod
  • pkg/services/CLAUDE.md
  • pkg/services/adapter_status.go
  • pkg/services/cluster.go
  • pkg/services/generic.go
  • pkg/services/node_pool.go
  • pkg/services/resource.go
💤 Files with no reviewable changes (9)
  • .bingo/.gitignore
  • .bingo/README.md
  • .bingo/gotestsum.mod
  • .bingo/go.mod
  • .bingo/mockgen.mod
  • .bingo/variables.env
  • .bingo/golangci-lint.mod
  • .bingo/oapi-codegen.mod
  • .bingo/Variables.mk

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Migrated tool dependency management from Bingo to Go 1.24+ native tool directives in go.mod.
    • Added tools make target for installing pinned tool versions.
  • Documentation

    • Updated development and setup guidance to reflect new tool installation workflow.
  • Dependencies

    • Updated direct and indirect module versions, including gomega and cobra.

Walkthrough

This PR removes the Bingo tool version pinning system entirely and replaces it with Go 1.24+ native tool directives. The .bingo/ directory structure (Variables.mk, *.mod files, variables.env) is deleted. The go.mod gains a tool (...) block pinning golangci-lint, oapi-codegen, mockgen, and gotestsum, while direct dependencies are bumped and indirect transitive deps are updated. The Makefile discards bingo variable wiring and rewires all tool invocations to use go tool. All go:generate directives across service files and docs switch from mockgen-v0.6.0 to go tool mockgen. Documentation and build comments are updated to reflect the new approach.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: replacing bingo tool management with native Go 1.24 tool directives.
Description check ✅ Passed The description is directly related to the changeset, explaining the removal of bingo and migration to go.mod tool directives with pinned versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed No log statements with secrets, tokens, passwords found. PR only contains build tooling changes: Bingo removal, Makefile updates, go.mod tool directives, and //go:generate updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands and usage tips.

Remove bingo tool management in favor of native `tool` directives
in go.mod (Go 1.24+). Tool versions are pinned in go.mod/go.sum
and resolved via `go tool <name>`.

Pinned versions (unchanged from bingo):
- golangci-lint v2.7.0
- oapi-codegen v2.6.0
- mockgen v0.6.0
- gotestsum v1.13.0
@hyperfleet-ci-bot
Copy link
Copy Markdown

Risk Score: 4 — risk/high

Signal Detail Points
PR size 2293 lines (>500) +2
Sensitive paths none +0
Test coverage No _test.go files in diff +2

Computed by hyperfleet-risk-scorer

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 3, 2026

@kuudori: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-commits a827b17 link true /test validate-commits

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant