chore: replace bingo with Go 1.24 tool directives#203
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (20)
💤 Files with no reviewable changes (9)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR removes the Bingo tool version pinning system entirely and replaces it with Go 1.24+ native Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Remove bingo tool management in favor of native `tool` directives in go.mod (Go 1.24+). Tool versions are pinned in go.mod/go.sum and resolved via `go tool <name>`. Pinned versions (unchanged from bingo): - golangci-lint v2.7.0 - oapi-codegen v2.6.0 - mockgen v0.6.0 - gotestsum v1.13.0
Risk Score: 4 —
|
| Signal | Detail | Points |
|---|---|---|
| PR size | 2293 lines (>500) | +2 |
| Sensitive paths | none | +0 |
| Test coverage | No _test.go files in diff | +2 |
Computed by hyperfleet-risk-scorer
|
@kuudori: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Remove bingo tool management in favor of native
tooldirectives in go.mod (Go 1.24+). Tool versions are pinned in go.mod/go.sum and resolved viago tool <name>.Pinned versions (unchanged from bingo):
Summary
Test Plan
make test-allpassesmake lintpassesmake test-helm(if applicable)