MON-4579: Remove NodeSelector and Tolerations from NodeExporterConfig

[danielmellado]

Node-exporter runs as a DaemonSet that must run on all nodes, so
nodeSelector and tolerations fields are not meaningful for it.

This PR removesthese fields from the CRD API along with their
associated tests.

Signed-off-by: Daniel Mellado dmellado@fedoraproject.org

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @danielmellado! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

The NodeExporterConfig Go type had the nodeSelector and tolerations fields removed and replaced with TOMBSTONE comment markers reserving their JSON names. Tests were updated to remove those fields from the “with all fields” initial/expected payloads and a tolerations-related test was relocated; collector-related tests remain. The ClusterMonitoring CRD descriptions were edited: nodeSelector min/max note removed, resources default request values updated, and tolerations documented as empty/unset by default.

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is clearly related to the changeset, explaining the rationale for removing nodeSelector and tolerations fields and confirming these removals from the CRD API and tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All test names are static and deterministic. No UUIDs, timestamps, generated identifiers, pod names, namespace names, IP addresses, or variable substitution found in test titles.
Test Structure And Quality	✅ Passed	Tests properly use BeforeEach/AfterEach, include timeouts, have meaningful assertions, and maintain single responsibility. Invalid test scenarios appropriately removed.
Microshift Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It only modifies YAML schema validation test files and Go type definitions. The custom check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR. The changes are API struct modifications, CRD definitions, and CRD validation test manifests (YAML). The check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR removes scheduling constraints from NodeExporterConfig. Since node-exporter runs as DaemonSet on all nodes, removing nodeSelector and tolerations makes it more topology-appropriate.
Ote Binary Stdout Contract	✅ Passed	Tests/suite_test.go properly redirects logging to GinkgoWriter via zap. No stdout violations: no fmt.Print/Println/Printf, klog, or problematic log.SetOutput in process-level code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It only modifies CRD type definitions, YAML test cases for API validation, and CRD schema files. The custom check is not applicable.
Title check	✅ Passed	The title accurately describes the main change: removing nodeSelector and tolerations fields from NodeExporterConfig.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[danielmellado]

@everettraven CI failures are expected as per the 'NoFieldRemoval', we'd need to override that, thanks in advance!

[everettraven]

@danielmellado The verify-crdify and verify-crd-schema checks can be overridden in this case, but it looks like verify has a legitimate failure. Make sure all the generated files are appropriately updated with make update and that should resolve the issue. You can run make verify locally to run the same verification checks as CI.

Aside from that failing test, this LGTM

[danielmellado]

@danielmellado The verify-crdify and verify-crd-schema checks can be overridden in this case, but it looks like verify has a legitimate failure. Make sure all the generated files are appropriately updated with make update and that should resolve the issue. You can run make verify locally to run the same verification checks as CI.

Aside from that failing test, this LGTM

thanks Bryce, totally forgot to run make update this time xD

[openshift-ci-robot]

@danielmellado: This pull request references MON-4579 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Node-exporter runs as a DaemonSet that must run on all nodes, so
nodeSelector and tolerations fields are not meaningful for it.

This PR removesthese fields from the CRD API along with their
associated tests.

Signed-off-by: Daniel Mellado dmellado@fedoraproject.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[danielmellado]

/jira refresh

[openshift-ci-robot]

@danielmellado: This pull request references MON-4579 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

/lgtm

/override ci/prow/verify-crd-schema
/override ci/prow/verify-crdify

[openshift-ci]

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-crd-schema, ci/prow/verify-crdify

Details

In response to this:

/lgtm

/override ci/prow/verify-crd-schema
/override ci/prow/verify-crdify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[everettraven]

@danielmellado Over to you for how you want to get the verified label

[danielmellado]

/verified by ci

[danielmellado]

@danielmellado Over to you for how you want to get the verified label

thanks!

[openshift-ci-robot]

@danielmellado: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 73d7ca9 and 2 for PR HEAD 796e97d in total

[openshift-ci]

@danielmellado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift-conformance	796e97d	link	true	/test e2e-aws-ovn-hypershift-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.