Skip to content

CCO-849: bump go toolchain to 1.26.5 to resolve snyk complaints#1065

Open
dlom wants to merge 1 commit into
openshift:masterfrom
dlom:mold/bump-go-toolchan-1265
Open

CCO-849: bump go toolchain to 1.26.5 to resolve snyk complaints#1065
dlom wants to merge 1 commit into
openshift:masterfrom
dlom:mold/bump-go-toolchan-1265

Conversation

@dlom

@dlom dlom commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

ci/prow/security is failing... again...

Summary by CodeRabbit

  • Chores
    • Updated the Go toolchain to version 1.26.5.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Walkthrough

The go.mod toolchain directive is updated from Go 1.26.4 to Go 1.26.5.

Changes

Go toolchain update

Layer / File(s) Summary
Update toolchain directive
go.mod
Changes the toolchain directive from go1.26.4 to go1.26.5.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

  • openshift/zero-trust-workload-identity-manager#61 — Updates the Go toolchain directive to a newer Go version.
  • openshift/cluster-kube-storage-version-migrator-operator#134 — Updates the Go toolchain directive to a newer Go version.
  • openshift/pf-status-relay-operator#49 — Updates the Go toolchain directive to a newer Go version.

Suggested reviewers: jstuever

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only go.mod changed (toolchain update); no test titles or test files were modified.
Test Structure And Quality ✅ Passed Only go.mod changed the Go toolchain; no Ginkgo tests or test behavior were modified.
Microshift Test Compatibility ✅ Passed Only go.mod changed (toolchain bump); no Ginkgo tests or MicroShift-sensitive APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only go.mod changed to bump the Go toolchain; no new Ginkgo/e2e tests were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only go.mod changed to bump the Go toolchain; no manifests, controllers, or scheduling logic were modified.
Ote Binary Stdout Contract ✅ Passed Only go.mod changed (toolchain 1.26.4→1.26.5); no process-level stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only go.mod changed; no new Ginkgo e2e tests or networking code were added, so the IPv6/disconnected-network check is not applicable.
No-Weak-Crypto ✅ Passed PASS: The PR only bumps the Go toolchain in go.mod; the changed file contains no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto code.
Container-Privileges ✅ Passed HEAD only changes go.mod to bump the Go toolchain; no container/K8s manifests were modified, so the privilege check is not applicable.
No-Sensitive-Data-In-Logs ✅ Passed Only go.mod toolchain version changed; no code or logging paths were modified.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately states the main change: bumping the Go toolchain to 1.26.5 to address security complaints.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested a review from jstuever July 10, 2026 16:47
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2026
@dlom

dlom commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/retitle CCO-849: bump go toolchain to 1.26.5 to resolve snyk complaints

@openshift-ci openshift-ci Bot changed the title NOJIRA: bump go toolchain to 1.26.5 to resolve snyk complaints CCO-849: bump go toolchain to 1.26.5 to resolve snyk complaints Jul 10, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@dlom: This pull request references CCO-849 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

ci/prow/security is failing... again...

Summary by CodeRabbit

  • Chores
  • Updated the Go toolchain to version 1.26.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dlom

dlom commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

@dlom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift fa2e57d link true /test e2e-hypershift
ci/prow/e2e-aws-ovn fa2e57d link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants