Skip to content

CCO-834: Upgrade to Kubernetes 1.36#1066

Draft
ericahinkleRH wants to merge 2 commits into
openshift:masterfrom
ericahinkleRH:CCO-834
Draft

CCO-834: Upgrade to Kubernetes 1.36#1066
ericahinkleRH wants to merge 2 commits into
openshift:masterfrom
ericahinkleRH:CCO-834

Conversation

@ericahinkleRH

Copy link
Copy Markdown

Summary

  • Upgrade Kubernetes dependencies from v0.35.2 to v0.36.0
  • Upgrade controller-runtime from v0.23.3 to v0.24.0 (required pairing for Kubernetes 1.36)
  • Bump github.com/openshift/api to a version compatible with APIs removed in Kubernetes 1.36
  • Regenerate codegen (hack/update-codegen.sh); remove empty zz_generated.defaults.go (no longer emitted by k8s 1.36 code-generator)
  • Apply temporary vendor patch to library-go test helpers for HasSyncedChecker() until openshift/library-go#2171 merges

Dependency changes

Module Before After
k8s.io/* v0.35.2 v0.36.0
sigs.k8s.io/controller-runtime v0.23.3 v0.24.0
github.com/openshift/api v0.0.0-20260317165824-54a3998d81eb v0.0.0-20260709102940-580f1c1ba691

No application logic changes.

library-go vendor patch

Kubernetes 1.36 added HasSyncedChecker() to the SharedIndexInformer interface. Upstream library-go does not implement this yet (#2171). The vendor patch in vendor/github.com/openshift/library-go/pkg/operator/v1helpers/test_helpers.go matches the upstream proposed fix and only affects test helper fakes. It can be removed on the next library-go bump after #2171 merges.

Test plan

  • make build
  • make test
  • make vet
  • verify-vendored-crds
  • hack/verify-codegen.sh
  • CI make verify
  • CI e2e (if run on branch)

Update Kubernetes dependencies to v0.36.0 and controller-runtime to
v0.24.0. Bump openshift/api for compatibility with APIs removed in
Kubernetes 1.36. Regenerate codegen and apply a temporary library-go
vendor patch for HasSyncedChecker until openshift/library-go#2171 merges.

Assisted-by: Claude
@openshift-ci-robot

openshift-ci-robot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@ericahinkleRH: This pull request references CCO-834 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Upgrade Kubernetes dependencies from v0.35.2 to v0.36.0
  • Upgrade controller-runtime from v0.23.3 to v0.24.0 (required pairing for Kubernetes 1.36)
  • Bump github.com/openshift/api to a version compatible with APIs removed in Kubernetes 1.36
  • Regenerate codegen (hack/update-codegen.sh); remove empty zz_generated.defaults.go (no longer emitted by k8s 1.36 code-generator)
  • Apply temporary vendor patch to library-go test helpers for HasSyncedChecker() until openshift/library-go#2171 merges

Dependency changes

Module Before After
k8s.io/* v0.35.2 v0.36.0
sigs.k8s.io/controller-runtime v0.23.3 v0.24.0
github.com/openshift/api v0.0.0-20260317165824-54a3998d81eb v0.0.0-20260709102940-580f1c1ba691

No application logic changes.

library-go vendor patch

Kubernetes 1.36 added HasSyncedChecker() to the SharedIndexInformer interface. Upstream library-go does not implement this yet (#2171). The vendor patch in vendor/github.com/openshift/library-go/pkg/operator/v1helpers/test_helpers.go matches the upstream proposed fix and only affects test helper fakes. It can be removed on the next library-go bump after #2171 merges.

Test plan

  • make build
  • make test
  • make vet
  • verify-vendored-crds
  • hack/verify-codegen.sh
  • CI make verify
  • CI e2e (if run on branch)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2026
@openshift-ci openshift-ci Bot requested review from dlom and jstuever July 10, 2026 17:59
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ericahinkleRH
Once this PR has been reviewed and has the lgtm label, please assign jstuever for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ericahinkleRH, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: afb8fc08-a17b-447c-a4bb-d38efc013843

📥 Commits

Reviewing files that changed from the base of the PR and between afb3f3c and e28cbbf.

📒 Files selected for processing (1)
  • deps.diff

Walkthrough

The pull request updates the Go dependency set across OpenShift, Kubernetes, controller-runtime, and transitive ecosystems. It also removes the generated no-op RegisterDefaults implementation from the cloud credential API package.

Changes

Dependency and generated-code refresh

Layer / File(s) Summary
Core dependency alignment
go.mod
OpenShift API, Kubernetes modules, controller-runtime, and the backoff module are advanced to newer versions.
Transitive dependency refresh
go.mod
Indirect OpenAPI, gateway, Prometheus, OpenTelemetry, protobuf, Go, and Kubernetes dependencies are updated, including stable structured-merge-diff.
Generated default removal
pkg/apis/cloudcredential/v1/zz_generated.defaults.go
The no-op generated RegisterDefaults function is removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.30%. Comparing base (87085f7) to head (afb3f3c).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
+ Coverage   47.03%   47.30%   +0.26%     
==========================================
  Files          97       97              
  Lines       12583    12614      +31     
==========================================
+ Hits         5919     5967      +48     
+ Misses       6008     5987      -21     
- Partials      656      660       +4     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericahinkleRH ericahinkleRH marked this pull request as draft July 10, 2026 18:12
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2026
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@ericahinkleRH: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security afb3f3c link true /test security
ci/prow/verify-deps afb3f3c link true /test verify-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Track the temporary vendor patch for HasSyncedChecker() in deps.diff
as required by the verify-deps check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants