CCO-834: Upgrade to Kubernetes 1.36#1066
Conversation
Update Kubernetes dependencies to v0.36.0 and controller-runtime to v0.24.0. Bump openshift/api for compatibility with APIs removed in Kubernetes 1.36. Regenerate codegen and apply a temporary library-go vendor patch for HasSyncedChecker until openshift/library-go#2171 merges. Assisted-by: Claude
|
@ericahinkleRH: This pull request references CCO-834 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ericahinkleRH The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request updates the Go dependency set across OpenShift, Kubernetes, controller-runtime, and transitive ecosystems. It also removes the generated no-op ChangesDependency and generated-code refresh
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1066 +/- ##
==========================================
+ Coverage 47.03% 47.30% +0.26%
==========================================
Files 97 97
Lines 12583 12614 +31
==========================================
+ Hits 5919 5967 +48
+ Misses 6008 5987 -21
- Partials 656 660 +4 🚀 New features to boost your workflow:
|
|
@ericahinkleRH: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Track the temporary vendor patch for HasSyncedChecker() in deps.diff as required by the verify-deps check.
Summary
github.com/openshift/apito a version compatible with APIs removed in Kubernetes 1.36hack/update-codegen.sh); remove emptyzz_generated.defaults.go(no longer emitted by k8s 1.36 code-generator)library-gotest helpers forHasSyncedChecker()until openshift/library-go#2171 mergesDependency changes
k8s.io/*sigs.k8s.io/controller-runtimegithub.com/openshift/apiNo application logic changes.
library-go vendor patch
Kubernetes 1.36 added
HasSyncedChecker()to theSharedIndexInformerinterface. Upstreamlibrary-godoes not implement this yet (#2171). The vendor patch invendor/github.com/openshift/library-go/pkg/operator/v1helpers/test_helpers.gomatches the upstream proposed fix and only affects test helper fakes. It can be removed on the nextlibrary-gobump after #2171 merges.Test plan
make buildmake testmake vetverify-vendored-crdshack/verify-codegen.shmake verify