Skip to content

Add prodsec-recommended CodeRabbit security rules#16

Open
onmete wants to merge 3 commits into
openshift:mainfrom
onmete:chore/prodsec-coderabbit-config
Open

Add prodsec-recommended CodeRabbit security rules#16
onmete wants to merge 3 commits into
openshift:mainfrom
onmete:chore/prodsec-coderabbit-config

Conversation

@onmete
Copy link
Copy Markdown
Contributor

@onmete onmete commented May 26, 2026

Summary

  • Adopts the Red Hat Product Security recommended CodeRabbit configuration from openshift/coderabbit#17, sourced from prodsec-skills
  • Adds 6 global review instructions (no-hardcoded-secrets, no-weak-crypto, no-injection-vectors, container-privileges, no-sensitive-data-in-logs, ai-attribution)
  • Adds 18 path-specific security review blocks covering injection, web, crypto, containers, K8s/OpenShift, MCP server/client, agents, LLM, supply chain, CI/CD, auth, API gateway, Go, C/C++, database, messaging, and model registry
  • Enables security scanners: gitleaks, semgrep, checkov, hadolint, trivy, osvScanner, actionlint, ast-grep
  • Adds knowledge base auto-indexing of AGENTS.md, CLAUDE.md, CONTRIBUTING.md
  • Adds path_filters for node_modules, dist, minified JS, yarn.lock

Test plan

  • Verify CodeRabbit picks up the new config on the next PR
  • Confirm no false-positive noise from path_instructions on unrelated file types

Made with Cursor

@openshift-ci openshift-ci Bot requested review from blublinsky and xrajesh May 26, 2026 12:05
onmete and others added 3 commits June 3, 2026 19:51
Adopts the security configuration from openshift/coderabbit#17 which adds
Red Hat Product Security recommended review rules, path-specific security
instructions, security scanner tooling, and knowledge base indexing.

Adds:
- Global review instructions (secrets, crypto, injection, container
  privileges, sensitive logging, AI attribution)
- 18 path-specific security review blocks (injection, web, crypto,
  containers, K8s/OpenShift, MCP, agents, LLM, supply chain, CI/CD,
  auth, API gateway, Go, C/C++, database, messaging, model registry)
- Security scanners: gitleaks, semgrep, checkov, hadolint, trivy,
  osvScanner, actionlint, ast-grep
- Knowledge base auto-indexing of AGENTS.md, CLAUDE.md, CONTRIBUTING.md
- Additional path_filters for node_modules, dist, minified JS, yarn.lock

Co-authored-by: Cursor <cursoragent@cursor.com>
Noise reduction — disable defaults that add clutter without value:
- in_progress_fortune, suggested_labels, suggested_reviewers,
  estimate_code_review_effort, related_prs
- finishing_touches for docstrings and unit_tests (prevents
  CodeRabbit from opening follow-up PRs)

Useful additions:
- language: en-US, early_access: true
- tone_instructions: direct and concise, focus on bugs/security
- high_level_summary_in_walkthrough: true
- enable_prompt_for_ai_agents: true (AI-friendly inline prompts)
- knowledge_base.jira: auto (cross-reference Jira issues)
- knowledge_base.linked_repositories: sandbox repo for cross-repo
  dependency awareness
- tools: shellcheck, golangci-lint, yamllint (language-specific linters)

Co-authored-by: Cursor <cursoragent@cursor.com>
- Use recursive glob patterns (**/node_modules/**, **/dist/**,
  **/*.min.js, **/yarn.lock) so nested projects are covered
- Add Cargo.lock to the supply-chain path_instructions glob
  alongside Cargo.toml for consistency

Co-authored-by: Cursor <cursoragent@cursor.com>
@onmete onmete force-pushed the chore/prodsec-coderabbit-config branch from c14af6a to d725068 Compare June 3, 2026 17:52
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Warning

Review limit reached

@onmete, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 36 minutes and 15 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4dc6157e-67ad-47f0-bb2a-a7f60154d155

📥 Commits

Reviewing files that changed from the base of the PR and between eed7142 and d725068.

📒 Files selected for processing (1)
  • .coderabbit.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raptorsun for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 3, 2026

@onmete: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant